Translation with params not included in payload generation #5302
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -33,7 +33,7 @@ export class UpdateMessageTemplate { | |||
| updatePayload.name = command.name; | |||
| } | |||
|
|
|||
| if (command.content !== null) { | |||
| if (command.content !== null || command.content !== undefined) { | |||
There was a problem hiding this comment.
Related to a different PR, added it here after a comment there
| const pairVariables = bod | ||
| .filter((body) => body.type === 'HashPair') | ||
| .flatMap((body) => { | ||
| const varName = body.value?.original as string; | ||
|
|
||
| if (!shouldAddVariable(varName)) { | ||
| return []; | ||
| } | ||
|
|
||
| return { | ||
| type: TemplateVariableTypeEnum.STRING, | ||
| name: body.value?.original as string, | ||
| defaultValue: '', | ||
| required: false, | ||
| }; | ||
| }); | ||
|
|
There was a problem hiding this comment.
This could be used in the future for other handlebars helpers that we might want to allow variables assignments in.
There was a problem hiding this comment.
maybe we should extract it to a reusable function then?
…ith-params-not-included-in-payload-generation
|
|
||
| return { | ||
| type: TemplateVariableTypeEnum.STRING, | ||
| name: body.value?.original as string, |
There was a problem hiding this comment.
| name: body.value?.original as string, | |
| name: varName, |
| const pairVariables = bod | ||
| .filter((body) => body.type === 'HashPair') | ||
| .flatMap((body) => { | ||
| const varName = body.value?.original as string; | ||
|
|
||
| if (!shouldAddVariable(varName)) { | ||
| return []; | ||
| } | ||
|
|
||
| return { | ||
| type: TemplateVariableTypeEnum.STRING, | ||
| name: body.value?.original as string, | ||
| defaultValue: '', | ||
| required: false, | ||
| }; | ||
| }); | ||
|
|
There was a problem hiding this comment.
maybe we should extract it to a reusable function then?
| if (body.path.original === HandlebarHelpersEnum.I18N) { | ||
| if (body.path?.original === HandlebarHelpersEnum.I18N) { | ||
| if (body.hash?.pairs) { | ||
| return getTemplateVariables(body.hash.pairs); |
There was a problem hiding this comment.
I'm not sure if we need a recurrent call here?
Can't we just use the extracted above function (lines 13-29) to get the variables?
There was a problem hiding this comment.
Currently, yes, you are right @LetItRock . But when we have time, in the cooldown maybe I want to go back to it and add support for sub expressions. In i18n, but also for general use. And that will need the recurrent calls.
For example:
{{titlecase (uppercase msg) }} (not a useful example, but just to show my point)
or for i18n
{{i18n "group.key" var=(titlecase msg) }}
msg in both examples would not be recognized as a variable, and in the first example it would set uppercase as a variable instead.
I do have something working for those states, but it requires some more work. I didn't want to over do it with the time as I feel its not the biggest priority
…ror-jsonparseanonymous Unhandled Error: SyntaxError JSON.parse(<anonymous>)
…-in-payload-generation
ainouzgali
deleted the
nv-3550-translation-with-params-not-included-in-payload-generation
branch
What change does this PR introduce?
Params used within a translation are not being recognized as workflow variables and are not included in the created payload trigger.
example:
{{i18n "test.key" var=payload-var}}=>payload-varshould be included in the trigger snippet :novu.trigger(......, payload: { payload-var: ...})Why was this change needed?
Other information (Screenshots)