fix(api): analytics module #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| controllers: [AnalyticsController], | ||
| providers: [AnalyticsService, HubspotIdentifyFormUsecase], | ||
| providers: [HubspotIdentifyFormUsecase], |
There was a problem hiding this comment.
Suggested change
| providers: [HubspotIdentifyFormUsecase], | |
| providers: [analyticsService, HubspotIdentifyFormUsecase], |
There was a problem hiding this comment.
feels like you were missing the process.env.SEGMENT_TOKEN injection? was there something else?
There was a problem hiding this comment.
It's already imported under the SharedModule, so I think I would love to have a single instance of it
There was a problem hiding this comment.
It's confusing, but that's how all of our service are exported from app generic
There was a problem hiding this comment.
got it, i was not sure if it would create 2 instances.
|
|
||
| @Module({ | ||
| imports: [HttpModule], | ||
| imports: [SharedModule, HttpModule], |
There was a problem hiding this comment.
Suggested change
| imports: [SharedModule, HttpModule], | |
| imports: [HttpModule], |
djabarovgeorge
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Mis import of the analytics module, caused FE events to be dismissed.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer