Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): analytics module #6684

Merged
merged 1 commit into from
Oct 13, 2024
Merged

fix(api): analytics module #6684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api/src/app/analytics/analytics.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Module } from '@nestjs/common';
import { AnalyticsService } from '@novu/application-generic';
import { HttpModule } from '@nestjs/axios';
import { AnalyticsController } from './analytics.controller';
import { HubspotIdentifyFormUsecase } from './usecases/hubspot-identify-form/hubspot-identify-form.usecase';
import { SharedModule } from '../shared/shared.module';

@Module({
imports: [HttpModule],
imports: [SharedModule, HttpModule],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
imports: [SharedModule, HttpModule],
imports: [HttpModule],

controllers: [AnalyticsController],
providers: [AnalyticsService, HubspotIdentifyFormUsecase],
providers: [HubspotIdentifyFormUsecase],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
providers: [HubspotIdentifyFormUsecase],
providers: [analyticsService, HubspotIdentifyFormUsecase],

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like you were missing the process.env.SEGMENT_TOKEN injection? was there something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already imported under the SharedModule, so I think I would love to have a single instance of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confusing, but that's how all of our service are exported from app generic

CleanShot 2024-10-13 at 17 41 30@2x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, i was not sure if it would create 2 instances.

})
export class AnalyticsModule {}
Loading