Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-service): SDK test updates #7315

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

tatarco
Copy link
Contributor

@tatarco tatarco commented Dec 17, 2024

What changed? Why was the change needed?

  • Test Changes:
    • all notifications related.
    • all subscriber related.
  • removed message entity from api layer.
  • fixed multiple decorations regarding openApi
    -removed trigger reference inside the session object, direct usage from sdk now

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Dec 17, 2024

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 3879bcd
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67694f3c8dda380008c95bb0
😎 Deploy Preview https://deploy-preview-7315.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 3879bcd
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67694f3c2a17b200089c7d8c
😎 Deploy Preview https://deploy-preview-7315.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

@novu/client

npm i https://pkg.pr.new/novuhq/novu/@novu/client@7315

@novu/headless

npm i https://pkg.pr.new/novuhq/novu/@novu/headless@7315

@novu/framework

npm i https://pkg.pr.new/novuhq/novu/@novu/framework@7315

@novu/js

npm i https://pkg.pr.new/novuhq/novu/@novu/js@7315

@novu/nest

npm i https://pkg.pr.new/novuhq/novu/@novu/nest@7315

@novu/nextjs

npm i https://pkg.pr.new/novuhq/novu/@novu/nextjs@7315

@novu/node

npm i https://pkg.pr.new/novuhq/novu/@novu/node@7315

@novu/notification-center

npm i https://pkg.pr.new/novuhq/novu/@novu/notification-center@7315

novu

npm i https://pkg.pr.new/novuhq/novu@7315

@novu/providers

npm i https://pkg.pr.new/novuhq/novu/@novu/providers@7315

@novu/react

npm i https://pkg.pr.new/novuhq/novu/@novu/react@7315

@novu/react-native

npm i https://pkg.pr.new/novuhq/novu/@novu/react-native@7315

@novu/shared

npm i https://pkg.pr.new/novuhq/novu/@novu/shared@7315

@novu/stateless

npm i https://pkg.pr.new/novuhq/novu/@novu/stateless@7315

commit: 3879bcd

@tatarco tatarco force-pushed the nv-4965-e2e-testing-happy-path-notifications branch from 3360cd9 to 16de0b5 Compare December 19, 2024 06:05
@tatarco tatarco force-pushed the nv-4965-e2e-testing-happy-path-notifications branch from 08aa7d0 to b30d84c Compare December 19, 2024 06:15
@tatarco tatarco requested a review from a team as a code owner December 19, 2024 06:15
@tatarco tatarco requested review from SokratisVidros and scopsy and removed request for a team December 19, 2024 06:15
@tatarco tatarco force-pushed the nv-4965-e2e-testing-happy-path-notifications branch from 76a3063 to 7e2e7c1 Compare December 23, 2024 05:01
@tatarco tatarco force-pushed the nv-4965-e2e-testing-happy-path-notifications branch from 7e2e7c1 to 59c6011 Compare December 23, 2024 08:23
@tatarco tatarco changed the title feat(api): SDK test updates feat(api-service): SDK test updates Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant