Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add run-script workspaces #2864

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Mar 15, 2021

  • Add workspaces-related configs:
    • workspace: list of workspaces names/dir to filter for
    • workspaces: boolean value to enable/disable workspaces awareness
    • adds the proposed note in the docs of each of the commands
      that are not affected by these configs.
  • Add workspaces support to npm run-script
    • add ability to serially run lifecycle scripts in workspaces
    • add ability to list scripts for all workspaces
    • add colors to npm run (no args) output

References

Relates to: npm/rfcs#117
Fixes: npm/statusboard#276
Fixes: npm/statusboard#283
Fixes: npm/statusboard#284
Fixes: npm/statusboard#285
Fixes: npm/statusboard#286
Fixes: npm/statusboard#269

@ruyadorno ruyadorno requested a review from a team as a code owner March 15, 2021 04:36
@ruyadorno ruyadorno force-pushed the add-run-script-workspaces branch from 7f60959 to 28d5c7e Compare March 15, 2021 04:48
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:minor new backwards-compatible feature labels Mar 15, 2021
@ruyadorno ruyadorno added this to the OSS - Sprint 26 milestone Mar 15, 2021
@ruyadorno ruyadorno force-pushed the add-run-script-workspaces branch from 28d5c7e to dfbdbb9 Compare March 15, 2021 04:49
@ruyadorno ruyadorno added the pr: needs documentation pull request requires docs before merging label Mar 15, 2021
@ruyadorno ruyadorno force-pushed the add-run-script-workspaces branch from dfbdbb9 to 89e879f Compare March 15, 2021 05:08
lib/run-script.js Outdated Show resolved Hide resolved
test/lib/npm.js Outdated Show resolved Hide resolved
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this even with the feedback in case we want to say "yeah we can refine this later" cause it works and is pretty darn good and we have lots of work to go in workspaces.

@ruyadorno ruyadorno force-pushed the add-run-script-workspaces branch from 89e879f to ec9f675 Compare March 15, 2021 15:02
@ruyadorno ruyadorno removed the pr: needs documentation pull request requires docs before merging label Mar 15, 2021
@ruyadorno
Copy link
Contributor Author

Updated with docs 😄

- Add workspaces-related configs:
  - workspace: list of workspaces names/dir to filter for
  - workspaces: boolean value to enable/disable workspaces awareness
  - adds the proposed note in the docs of each of the commands
    that are not affected by these configs.
- Add workspaces support to `npm run-script`
  - add ability to serially run lifecycle scripts in workspaces
  - add ability to list scripts for all workspaces
  - add colors to `npm run` (no args) output

Relates to: npm/rfcs#117
Fixes: npm/statusboard#276
Fixes: npm/statusboard#283
Fixes: npm/statusboard#284
Fixes: npm/statusboard#285
Fixes: npm/statusboard#286

PR-URL: npm#2864
Credit: @ruyadorno
Close: npm#2864
Reviewed-by: @wraithgar
@ruyadorno ruyadorno changed the base branch from latest to release-next March 18, 2021 22:13
@ruyadorno ruyadorno force-pushed the add-run-script-workspaces branch from 96552a0 to 335cbc3 Compare March 18, 2021 22:14
@ruyadorno ruyadorno merged commit 335cbc3 into npm:release-next Mar 18, 2021
ruyadorno added a commit that referenced this pull request Mar 18, 2021
- Add workspaces-related configs:
  - workspace: list of workspaces names/dir to filter for
  - workspaces: boolean value to enable/disable workspaces awareness
  - adds the proposed note in the docs of each of the commands
    that are not affected by these configs.
- Add workspaces support to `npm run-script`
  - add ability to serially run lifecycle scripts in workspaces
  - add ability to list scripts for all workspaces
  - add colors to `npm run` (no args) output

Relates to: npm/rfcs#117
Fixes: npm/statusboard#276
Fixes: npm/statusboard#283
Fixes: npm/statusboard#284
Fixes: npm/statusboard#285
Fixes: npm/statusboard#286

PR-URL: #2864
Credit: @ruyadorno
Close: #2864
Reviewed-by: @wraithgar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature
Projects
None yet
2 participants