Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gar/test mocks #4645

Merged
merged 6 commits into from
Apr 4, 2022
Merged

Gar/test mocks #4645

merged 6 commits into from
Apr 4, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 30, 2022

Removing more mocks from tests.

@wraithgar wraithgar force-pushed the gar/test-mocks branch 2 times, most recently from aba3f33 to 31fa0e1 Compare March 30, 2022 23:00
@npm-robot
Copy link
Contributor

npm-robot commented Mar 30, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 56.895 ±5.02 35.693 ±0.42 22.507 ±0.42 24.852 ±0.43 3.848 ±0.30 3.772 ±0.06 3.025 ±0.06 15.040 ±0.20 2.946 ±0.07 4.350 ±0.03
#4645 60.165 ±2.39 36.532 ±0.34 22.865 ±0.18 25.156 ±0.43 3.774 ±0.08 3.890 ±0.07 3.023 ±0.00 15.013 ±0.12 2.951 ±0.03 4.638 ±0.30
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 43.370 ±2.85 28.653 ±0.45 17.066 ±0.14 18.226 ±0.51 3.559 ±0.10 3.523 ±0.01 3.096 ±0.10 11.216 ±0.18 2.932 ±0.04 3.914 ±0.09
#4645 44.966 ±3.35 28.301 ±0.01 16.614 ±0.36 17.932 ±0.41 3.506 ±0.02 3.497 ±0.05 3.167 ±0.01 11.175 ±0.11 2.868 ±0.02 3.880 ±0.13

@wraithgar wraithgar force-pushed the gar/test-mocks branch 6 times, most recently from fc03cfb to b573bc1 Compare April 2, 2022 01:49
@wraithgar wraithgar marked this pull request as ready for review April 2, 2022 01:51
@wraithgar wraithgar requested a review from a team as a code owner April 2, 2022 01:51
@wraithgar
Copy link
Member Author

Ok I'm done with this round of test cleanups.

@lukekarrys
Copy link
Contributor

Looks like there's the possibility of a flaky test with a snapshot here: https://github.com/npm/cli/runs/5796752839?check_suite_focus=true#step:5:42

Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of clear improvements here 👍

* Removed dedupe --save documentation and attempted implementation.
* Remove some unneeded otplease mocks from test

`npm dedupe --save` didn't work in a easy to understand way. It would
only update a top level dependency that was duplicated in the tree.
Found this out rewriting the dedupe tests to be real.  This is not very
intuitive and it's best if folks use update or install for saving to
package.json.
@wraithgar
Copy link
Member Author

flaky test fixed, thanks @lukekarrys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants