Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 8.7.0 #42744

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 8.7.0 #42744

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

v8.7.0 (2022-04-13)

Features

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

Trott
Trott approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

trivikr
trivikr reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42744
✔  Done loading data for nodejs/node/pull/42744
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.7.0 (#42744)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-robot:npm-8.7.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.7.0
Committers 1
 - ops+robot@npmjs.com 
PR-URL: https://github.com/nodejs/node/pull/42744
Fixes: https://github.com/update
Fixes: https://github.com/replace
Fixes: https://github.com/remove
Fixes: https://github.com/do
Fixes: https://github.com/skip
Fixes: https://github.com/show
Fixes: https://github.com/mitigate
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42744
Fixes: https://github.com/update
Fixes: https://github.com/replace
Fixes: https://github.com/remove
Fixes: https://github.com/do
Fixes: https://github.com/skip
Fixes: https://github.com/show
Fixes: https://github.com/mitigate
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 14 Apr 2022 21:57:06 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42744#pullrequestreview-943039340
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42744#pullrequestreview-943047538
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/42744#pullrequestreview-943161793
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42744#pullrequestreview-943222626
   ℹ  This PR is being fast-tracked
   ⚠  GitHub cannot link the author of 'deps: upgrade npm to 8.7.0' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2171609158

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 16, 2022
Open
16 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43535/

@github-actions github-actions bot mentioned this pull request Apr 17, 2022
Open
15 tasks
@lpinca
Copy link
Member

lpinca commented Apr 17, 2022

Landed in c0d5f4b.

@lpinca lpinca closed this Apr 17, 2022
lpinca pushed a commit that referenced this pull request Apr 17, 2022
@lpinca
deps: upgrade npm to 8.7.0
c0d5f4b 
PR-URL: #42744
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Apr 18, 2022
Open
Open
Open
Open
@lukekarrys lukekarrys deleted the npm-8.7.0 branch April 22, 2022 03:51
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@xtx1130
deps: upgrade npm to 8.7.0
204c7fa 
PR-URL: nodejs#42744
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Apr 28, 2022
@targos
deps: upgrade npm to 8.7.0
294664e 
PR-URL: #42744
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request May 2, 2022
Merged
MylesBorins pushed a commit that referenced this pull request May 2, 2022
@MylesBorins
deps: upgrade npm to 8.7.0
f8b2156 
PR-URL: #42744
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ruyadorno pushed a commit that referenced this pull request May 27, 2022
@ruyadorno
deps: upgrade npm to 8.7.0
34e6edd 
PR-URL: #42744
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno mentioned this pull request May 30, 2022
Merged
@juanarbol juanarbol mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@trivikr trivikr trivikr approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@npm-robot @nodejs-github-bot @lpinca @Trott @tniessen @trivikr @VoltrexKeyva @targos @aduh95