-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add github action for release #4659
chore: add github action for release #4659
Conversation
16151fb
to
e2fa064
Compare
no statistically significant performance changes detected timing results
|
Converting to draft while we wait for |
f64563d
to
b2cff2c
Compare
c48f145
to
2094ad3
Compare
41e8395
to
fd77ade
Compare
fd77ade
to
c5aa3ba
Compare
c5aa3ba
to
6a1d4ce
Compare
|
||
publish: gitclean ls-ok link test smoke-tests docs prune | ||
@git push origin :v$(shell node bin/npm-cli.js --no-timing -v) 2>&1 || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our release process always includes us creating the tag before running this step, so this was unnecessary. It wasn't erroring but would show the message that the tag already existed.
- os: macos-latest | ||
shell: bash | ||
# XXX: this should be possible in windows also | ||
# but resetdeps cant be a bash script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost ready to run in Windows, but needs resetdeps and the rm -rf
to be cross platform. I'm saving that for a future PR.
Refactored this based on input from @nlf. Notable changes:
|
This adds an additional GitHub action that only runs when the head branch name starts with
release/
. This guarantees thattest-all
will run even now that we publish fromlatest
so the release PRs only contain a few files.