Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove stringify-package #4714

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

wraithgar
Copy link
Member

It was not being used

It was not being used
@wraithgar wraithgar requested a review from a team as a code owner April 9, 2022 02:38
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 62.573 ±8.16 31.294 ±0.18 18.565 ±0.15 20.778 ±0.81 3.275 ±0.01 3.268 ±0.02 2.676 ±0.07 11.964 ±0.09 2.583 ±0.01 3.642 ±0.03
#4714 64.806 ±1.16 30.828 ±0.16 23.667 ±7.55 20.811 ±0.80 3.220 ±0.03 3.215 ±0.01 2.557 ±0.03 12.073 ±0.04 2.589 ±0.01 3.732 ±0.17
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.931 ±2.57 24.130 ±0.03 13.493 ±0.15 14.526 ±0.14 2.890 ±0.01 2.918 ±0.02 2.572 ±0.01 9.002 ±0.06 2.423 ±0.01 3.275 ±0.00
#4714 38.814 ±0.75 24.145 ±0.02 13.752 ±0.01 14.805 ±0.27 2.925 ±0.01 2.949 ±0.06 2.583 ±0.00 9.015 ±0.00 2.431 ±0.01 3.262 ±0.03

@fritzy fritzy merged commit e33aa0f into latest Apr 12, 2022
@fritzy fritzy deleted the deps/remove-stringify-package branch April 12, 2022 00:26
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants