Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add more npm/node information to config ls #4723

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

lukekarrys
Copy link
Contributor

npm config ls has become helpful to ask users to post the output of in bug reports. This adds the npm __dirname, npm version, and node version. These aren't really "config" items but we already have process.execPath in there and I think these are as important as that.

I want to be mindful of making this have too much output, but these additions feel like a positive tradeoff to me.

@lukekarrys lukekarrys requested a review from a team as a code owner April 10, 2022 18:06
@npm-robot
Copy link
Contributor

npm-robot commented Apr 10, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 48.351 ±3.44 28.399 ±0.15 16.415 ±0.11 18.671 ±0.72 2.863 ±0.00 2.858 ±0.01 2.287 ±0.06 10.226 ±0.17 2.216 ±0.05 3.070 ±0.06
#4723 50.365 ±6.27 26.924 ±0.49 15.798 ±0.01 18.222 ±0.26 2.761 ±0.07 2.777 ±0.00 2.189 ±0.08 10.306 ±0.01 2.190 ±0.02 3.408 ±0.10
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.787 ±1.82 21.549 ±0.34 11.649 ±0.07 12.672 ±0.24 2.465 ±0.13 2.511 ±0.11 2.218 ±0.01 7.982 ±0.01 2.149 ±0.01 2.700 ±0.01
#4723 37.189 ±5.33 20.988 ±0.14 11.807 ±0.06 12.590 ±0.22 2.480 ±0.01 2.483 ±0.07 2.162 ±0.12 7.711 ±0.06 2.068 ±0.02 2.698 ±0.02

Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nvm debug for printing out info for a bug report. What about adding a npm debug whose purpose was to supply info for filed issues?

@lukekarrys
Copy link
Contributor Author

What about adding a npm debug whose purpose was to supply info for field issues?

I would be in favor of that (or refactoring doctor to take subcommands and have npm doctor debug). I think this is a nice bridge to that. Also linking to npm/statusboard#444 where we could have more discussion about this.

lib/commands/config.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants