Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): warn on deprecated configs #4740

Merged
merged 2 commits into from
Apr 13, 2022
Merged

feat(config): warn on deprecated configs #4740

merged 2 commits into from
Apr 13, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 13, 2022

Leaving as a draft until npm/config#62 is published and then this PR will also include that dep update.

@npm-robot
Copy link
Contributor

npm-robot commented Apr 13, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.939 ±1.68 36.426 ±0.07 22.366 ±0.11 26.135 ±0.72 3.783 ±0.06 3.784 ±0.07 2.979 ±0.07 15.602 ±0.14 2.996 ±0.02 4.100 ±0.09
#4740 79.210 ±24.73 42.339 ±7.48 22.659 ±0.34 25.442 ±0.12 3.670 ±0.05 3.680 ±0.04 2.934 ±0.01 15.495 ±0.02 2.898 ±0.05 4.246 ±0.04
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.959 ±2.43 28.450 ±0.08 16.736 ±0.13 17.701 ±0.21 3.366 ±0.02 3.380 ±0.04 2.942 ±0.01 11.174 ±0.03 2.789 ±0.01 3.814 ±0.04
#4740 45.027 ±0.30 32.052 ±4.72 17.125 ±0.27 17.868 ±0.54 3.362 ±0.05 3.351 ±0.04 3.028 ±0.16 11.268 ±0.20 2.795 ±0.05 3.817 ±0.01

@lukekarrys lukekarrys marked this pull request as ready for review April 13, 2022 16:46
@lukekarrys lukekarrys requested a review from a team as a code owner April 13, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants