Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] semver.satisfied false positive #587

Closed
1 task done
wraithgar opened this issue Jul 7, 2023 · 0 comments · Fixed by #588
Closed
1 task done

[BUG] semver.satisfied false positive #587

wraithgar opened this issue Jul 7, 2023 · 0 comments · Fixed by #588
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@wraithgar
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

From: npm/npm-pick-manifest#87 (review)

This now returns true: semver.satisfies('2.0.0', '== 1.0.0 || foo', { loose: true })) whereas it did not previously

Expected Behavior

Should return false

Steps To Reproduce

No response

Environment

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: trim each range set before parsing npm/node-semver
1 participant
@wraithgar