feat: decorate picked manifest with publish time #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
force-pushed
the
feelepxyz/add-time
branch
2 times, most recently
from
f487565
to
f382d1d
Compare
Decorate the manifest with the publish time from the packument if this exists for the picked version. This is used in pacote to pick a valid signing key when verifying registry signatures and attestations: npm/pacote#284 Signed-off-by: Philip Harrison <philip@mailharrison.com>
feelepxyz
force-pushed
the
feelepxyz/add-time
branch
from
f382d1d
to
75b319a
Compare
feelepxyz
commented
Jul 5, 2023
test/index.js
Outdated
There was a problem hiding this comment.
Looked into these test failures and can reproduce the issue with semver@7.5.2 and this commit specifically: npm/node-semver@717534e
This now returns true: semver.satisfies('2.0.0', '== 1.0.0 || foo', { loose: true })) whereas it did not previously
cc @lukekarrys
wraithgar
reviewed
Jul 5, 2023
Co-authored-by: Gar <wraithgar@github.com>
wraithgar
changed the title
wraithgar
reviewed
Jul 5, 2023
| @@ -185,6 +185,11 @@ const pickManifest = (packument, wanted, opts) => { | |||
|
|
|||
| module.exports = (packument, wanted, opts = {}) => { | |||
| const mani = pickManifest(packument, wanted, opts) | |||
| // Decorate with publish time if available | |||
| const _time = packument.time.?[mani?.version]] | |||
There was a problem hiding this comment.
looks like we got the . and ? swapped after time.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorate the manifest with the publish time from the packument if this exists for the picked version.
This is used in pacote to pick a valid signing key when verifying registry signatures and attestations:
npm/pacote#284