feat!: use AbortSignal instead of EventEmitter for opener #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the opener function will now receive an object with an abort signal which can be used to listen for the abort event intead of an event emitter
lukekarrys
force-pushed
the
lk/abort-signal
branch
from
3748027
to
c6acddd
Compare
|
This also refactors the control flow to prefer async/await over promise chains. |
wraithgar
reviewed
May 1, 2024
wraithgar
reviewed
May 1, 2024
wraithgar
reviewed
May 1, 2024
wraithgar
reviewed
May 1, 2024
lukekarrys
commented
May 1, 2024
lukekarrys
commented
May 1, 2024
lukekarrys
commented
May 1, 2024
wraithgar
reviewed
May 1, 2024
BREAKING CHANGE: `hostname` is no longer sent as part of the web auth body Co-authored-by: Gar <gar+gh@danger.computer>
lukekarrys
force-pushed
the
lk/abort-signal
branch
from
38040f2
to
b211b95
Compare
BREAKING CHANGE: this uses AbortSignal.throwIfAborted() which is not available in all versions of Node 16
|
@wraithgar re-requesting review. note this also drops Node 16 now since |
wraithgar
approved these changes
May 2, 2024
Merged
lukekarrys
pushed a commit
that referenced
this pull request
May 2, 2024
🤖 I have created a release *beep* *boop* --- ## [10.0.0](v9.0.2...v10.0.0) (2024-05-02) ###⚠️ BREAKING CHANGES * this uses AbortSignal.throwIfAborted() which is not available in all versions of Node 16 * `hostname` is no longer sent as part of the web auth body * the opener function will now receive an object with an abort signal which can be used to listen for the abort event intead of an event emitter ### Features * [`f67687d`](f67687d) [#131](#131) drop node 16 support (@lukekarrys) * [`d6f6ebe`](d6f6ebe) [#131](#131) remove hostname from body (@lukekarrys, @wraithgar) * [`c0bb22f`](c0bb22f) [#131](#131) add webAuthOpener method (@lukekarrys) * [`df44705`](df44705) [#131](#131) use AbortSignal instead of EventEmitter for opener (@lukekarrys) ### Bug Fixes * [`53db633`](53db633) [#131](#131) pass signal to webAuthCheckLogin timer (@lukekarrys) ### Dependencies * [`5c4221b`](5c4221b) [#133](#133) `npm-registry-fetch@17.0.1` (#133) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the opener function will now receive an object
with an abort signal which can be used to listen for the abort
event intead of an event emitter