Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: use AbortSignal instead of EventEmitter for opener #131

Merged
merged 5 commits into from
May 2, 2024
Merged

feat!: use AbortSignal instead of EventEmitter for opener #131

merged 5 commits into from
May 2, 2024

Commits on May 1, 2024

  1. feat!: use AbortSignal instead of EventEmitter for opener 

    BREAKING CHANGE: the opener function will now receive an object
with an abort signal which can be used to listen for the abort
event intead of an event emitter
    @lukekarrys
    lukekarrys committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c6acddd View commit details
    Browse the repository at this point in the history

  2. feat: add webAuthOpener method

    @lukekarrys
    lukekarrys committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9c38533 View commit details
    Browse the repository at this point in the history

  3. feat!: remove hostname from body 

    BREAKING CHANGE: `hostname` is no longer sent as part of the web auth body

Co-authored-by: Gar <gar+gh@danger.computer>
    @lukekarrys @wraithgar
    lukekarrys and wraithgar committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b211b95 View commit details
    Browse the repository at this point in the history

  4. fix: pass signal to webAuthCheckLogin timer

    @lukekarrys
    lukekarrys committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9c0e8d9 View commit details
    Browse the repository at this point in the history

  5. feat!: drop node 16 support 

    BREAKING CHANGE: this uses AbortSignal.throwIfAborted() which is not available
in all versions of Node 16
    @lukekarrys
    lukekarrys committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ca7eab7 View commit details
    Browse the repository at this point in the history