[nrf fromtree] Clear srp implementation #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform
zephyr
telink
esp32
linux
tizen
silabs
freeRTOS
labels
LipinskiPNordicSemi
changed the title
LipinskiPNordicSemi
force-pushed
the
srp_clear
branch
from
8b416c6 to
1786e09
Compare
LipinskiPNordicSemi
changed the title
| @@ -181,6 +181,12 @@ void ConfigurationManagerImpl::DoFactoryReset(intptr_t arg) | |||
| { | |||
| ChipLogProgress(DeviceLayer, "Performing factory reset"); | |||
|
|
|||
| #if CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT | |||
| ThreadStackMgr().WaitOnSrpClearAllComplete(); | |||
There was a problem hiding this comment.
Why isn't ThreadStackMgr().ClearAllSrpHostAndServices() enough? The other functions are called under the hood.
There was a problem hiding this comment.
I didn't check that, my bad
LipinskiPNordicSemi
force-pushed
the
srp_clear
branch
from
1786e09 to
1f496b0
Compare
Damian-Nordic
approved these changes
Mar 1, 2024
|
Thanks. What about manifest update? |
LipinskiPNordicSemi
force-pushed
the
srp_clear
branch
from
1f496b0 to
35c8841
Compare
…to the GenericThreadStackManagerImpl (#32215) * Bring the functionality to clear all Srp Client host and Services to the GenericThreadStackManagerImpl * Fix Tizen build * Update src/platform/Tizen/ThreadStackManagerImpl.cpp Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> * Add method documentation and address comments * Restyled by whitespace --------- Commit: 6350333 Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
LipinskiPNordicSemi
force-pushed
the
srp_clear
branch
from
35c8841 to
c43bd14
Compare
This commit implements the host srp clear, using cherry-picked upstream solution. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
LipinskiPNordicSemi
force-pushed
the
srp_clear
branch
from
c43bd14 to
493dcc3
Compare
|
This patch did not land in NCS 2.6.0. I will be pulled in by the next connectedhomeip upmerge. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the host srp clear, using a cherry-picked upstream solution.
Cherry-picked commit 6350333 content:
“This PR brings project-chip/connectedhomeip#31606 feature to The GenericThreadStackManagerImpl.
The functionality remains the same (with the addition of deleting the client key lease also).
However, this requires each platform that uses it, to provide a synchronization mechanism.
I created the Templates _WaitOnSrpClearAllComplete and _NotifySrpClearAllComplete and I provided an implementation for all platforms using the GenericThreadStackManagerImpl. (It is left unimplemented for others)
The synchronization mechanism I chose for Zephyr platforms (nordic/telink) and Infineon might not be optional so suggestions are welcome.
The functionality was only tested on the Silabs platform and is currently only used on it also. I am confident it works for all FreeRTOS-based platforms.
I suggest all other thread platform owners take some time to test and use ClearAllSrpHostAndServices during their factory-reset sequence.”