Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Clear srp implementation #14304

Closed

Conversation

LipinskiPNordicSemi
Copy link
Contributor

This commit implements the host srp clear, using a cherry-picked upstream solution.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 1, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 1, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@@ -40,3 +40,5 @@ CONFIG_USE_SEGGER_RTT=n
# Enable Factory Data feature
CONFIG_CHIP_FACTORY_DATA=y
CONFIG_CHIP_FACTORY_DATA_BUILD=y

CONFIG_CHIP_ENABLE_DNSSD_SRP=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be enabled in all Matter over Thread samples.

@Damian-Nordic
Copy link
Contributor

Changelog may be useful for this feature.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 1, 2024
@LipinskiPNordicSemi LipinskiPNordicSemi force-pushed the srp_clear branch 4 times, most recently from 310072a to b6678bb Compare March 4, 2024 09:54
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@v2.6.0-rc1 nrfconnect/sdk-connectedhomeip#399 nrfconnect/sdk-connectedhomeip#399/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@LuDuda LuDuda requested a review from wiba-nordic March 4, 2024 11:09
@LipinskiPNordicSemi LipinskiPNordicSemi force-pushed the srp_clear branch 2 times, most recently from 1c638ac to cac3a2d Compare March 5, 2024 08:11
This commit implements the host srp clear,
using a cherry-picked upstream solution.

Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
@markaj-nordic
Copy link
Contributor

This patch did not land in NCS 2.6.0. I will be pulled in by the next connectedhomeip upmerge. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants