-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@swc/helpers not included in package.json for nest apps with incr compiled libs #10270
Comments
nartc
added a commit
that referenced
this issue
May 12, 2022
AgentEnder
pushed a commit
that referenced
this issue
May 12, 2022
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
When bundling a Nest app with
@nrwl/node:webpack
where some of the apps libs are incrementally compiled with@nrwl/js:swc
the@swc/helpers
package is not included in the package.json with the--generatePackageJson
flag.I believe this is because the
@swc/helpers
lib is listed as adevDependency
so webpack ignores it. The only way I could get it to work is to add@swc/helpers
todependencies
and then doingimport '@swc/helpers';
in my appsmain.ts
file. That made the package show up in the generated package jsonExpected Behavior
If a library is used at runtime then it should be included in the package.json that is generated.
@swc/helpers
should probably be listed independencies
notdevDependencies
as it is a runtime dependency not a dev dependency.We should also not need to import it into the main.ts for it to be included as the compiled libraries use it, it is even included in the incrementally compiled libraries package.jsons as a dependency.
Steps to Reproduce
--generatePackageJson
@swc/helpers
is not in the generated package.jsonThis issue may not be prioritized if details are not provided to help us reproduce the issue.
Failure Logs
Environment
The text was updated successfully, but these errors were encountered: