fix(js): move swc/helpers to dependencies instead of devDependencies

[nartc]

ISSUES CLOSED: #10270

Current Behavior

@swc/helpers is added to lib's devDependencies causing runtime error for the library if the library uses swc/helpers utilities and it's not included in the generatedPackageJson.

Expected Behavior

@swc/helpers should be in dependencies

Related Issue(s)

Fixes #10270

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 38097d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=build --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6 --parallel=3
• nx affected --target=e2e --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6 --parallel=3
• nx affected --target=test --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6 --parallel=1
• nx build typedoc-theme
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=10040388e3332e0bdc2d96894ff304f3dec8cd97 --head=38097d9a79474e22a6d6fc87a900695a526711d6
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		May 12, 2022 at 6:57PM (UTC)

[yharaskrik]

While this does solve part of the problem, I feel like the @nrwl/node:webpack executor should be able to find the @swc/helpers library and included it in the generated package json, with this change we still need to import '@swc/helpers' in the apps main.ts. Should the webpack executor be able to find that dep itself? Or leave it up to the developers to add the import?

[nartc]

@yharaskrik the same thing happens for tslib. If you just build a Nest app, the built artifact does use tslib (decorators) but tslib isn't part of the generated package.json. So not sure if it's a limitation to nrwl/js IMHO. That said, I have this example where I run the built app in docker and I run npm install tslib explicitly as a separate step in the docker (https://github.com/nartc/nx-microservice-docker/blob/main/apps/order-api/dockerfile)

[AgentEnder]

@nartc is this still the case? We have merged #9350 which I thought fixed the tslib error. Maybe a similar approach could be used for @swc/helpers?

[nartc]

@AgentEnder nest app uses node:webpack. But yeah, similar approach could be used for swc/helpers

[AgentEnder]

Interesting, we should look at porting that logic for tslib over to the node:webpack executor as well as introducing similar for swc.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.