Drop outdated python 3.6, add support for python 3.10 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses the compatibility issue with 2.7 mentioned in #75 as well, the local tox tests passed. |
ross
previously approved these changes
Jul 23, 2022
|
@ross Thanks for your approval. However, it seems that a maintainer needs to approve to trigger the tests for me, since this is my first contribution to this repo. |
Yeah, I was just signaling that it makes sense to me. 😁 |
|
Going to force this through because the lint failure is not the fault of this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for python 3.10 (changed to collections.abc.Iterable) with fallback for legacy 2.7.
Dropped 3.6 since it reached EOL as per https://devguide.python.org/versions/
@ross FYI - this affects octodns_ns1 when using python 3.10.