Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup compatibility with Python 3.10 #75

Closed
wants to merge 1 commit into from

Conversation

ignatenkobrain
Copy link
Contributor

collections.Iterable was moved to collections.abc.Iterable in Python 3.8
but compatibility was preserved. In Python 3.10, old path was removed.

collections.Iterable was moved to collections.abc.Iterable in Python 3.8
but compatibility was preserved. In Python 3.10, old path was removed.
Copy link
Contributor

@mburtless mburtless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 thanks for the contribution! Unfortunately as is this will break compatibility with python 2.7 which still needs to be maintained. I think we'll either need to utilize the six module here or something like

try:
    from collections.abc import Callable  # noqa
except ImportError:
    from collections import Callable  # noqa

@istr
Copy link
Contributor

istr commented Oct 11, 2022

This has been addressed in v0.18.0.

@shane-ns1
Copy link
Contributor

Since the fix @mburtless suggested was implemented, I'm going to close this ticket. Thanks for pointing out the issue and giving a fix!

@shane-ns1 shane-ns1 closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants