tests: use GitHub Actions for CI #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sometimes this starts working right away, sometimes this file has to exist in master before it'll trigger on and use the changes in the pull requests ... |
ploxiln
force-pushed
the
github_actions
branch
from
5bb2069 to
21c5bfc
Compare
also add go-1.14 and go-1.15 to test matrix keep Travis-CI temporarily
ploxiln
force-pushed
the
github_actions
branch
from
21c5bfc to
3282dc1
Compare
ploxiln
changed the title
|
@mreiferson @jehiah do you mind if I merge this in order to get GitHub Actions enabled, and then finish it up in a follow-up PR? (changes to the actions take effect in the PR, but it has to exist in master to be enabled, I think?) |
jehiah
approved these changes
Nov 6, 2020
|
thanks |
|
aha, it did trigger https://github.com/nsqio/nsq/actions/runs/348930257 |
|
thanks for this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add go-1.14 and go-1.15 to test matrix
TODO: try to add back coveralls