tests: finish GitHub Actions CI setup #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
github_actions_v2
branch
from
901a73b to
b3d9b1f
Compare
|
I think this is ready to go, but feel free to suggest changes @jehiah @mreiferson |
mreiferson
requested changes
Nov 7, 2020
|
I suppose one other question is: can we make the coveralls build be informational only? |
|
I think you would make that change on the coveralls site, and I can't do that for nsqio/nsq, but you should see settings that look like this, and change the thresholds:
|
replace README build status badge, for GitHub Actions
ploxiln
force-pushed
the
github_actions_v2
branch
from
67a3454 to
cd14d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1295