nsqd: seperate broadcast ports for tcp and http #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyam-king
force-pushed
the
issue-1073
branch
from
2228a4c to
fa10dc1
Compare
ploxiln
reviewed
Nov 14, 2020
shyam-king
force-pushed
the
issue-1073
branch
from
fa10dc1 to
ca9c700
Compare
ploxiln
reviewed
Nov 15, 2020
mreiferson
requested changes
Nov 15, 2020
shyam-king
force-pushed
the
issue-1073
branch
from
ca9c700 to
42efe71
Compare
|
Can you squash down to one commit please? The prefix of the commit title should be "nsqd:" (I suggest a commit title like: "nsqd: add flags --broadcast-tcp-port, --broadcast-http-port") |
mreiferson
approved these changes
Nov 17, 2020
shyam-king
force-pushed
the
issue-1073
branch
2 times, most recently
from
a34709e to
f3d4e77
Compare
|
one last minor nit, commit title has "broadcast-http-address" instead of "broadcast-http-port" |
shyam-king
force-pushed
the
issue-1073
branch
from
f3d4e77 to
72b4ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using nsqd within containerised instances, we would require not only a different broadcast address but also different ports to which consumers must contact in order to reach the nsqd, thus, solving #1073 .
Changes
broadcast-tcp-addressandbroadcast-http-addressbroadcast-tcp-addressandbroadcast-http-addressinstead of the bound ports