Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation about broadcast tcp and http ports #70

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

sidvenu
Copy link
Contributor

@sidvenu sidvenu commented Nov 13, 2020

Adds documentation about features introduced in nsqio/nsq#1297.

@ploxiln
Copy link
Member

ploxiln commented Nov 23, 2020

@mreiferson should we delay merging this until around the time of the next release? or just merge now, and allow some small chance of confusion for people using the latest release?

@jehiah
Copy link
Member

jehiah commented Nov 23, 2020

@ploxiln speaking of "time for the next release" =)

@mreiferson
Copy link
Member

In an ideal world these would indicate version compatibility, but since we don't have that let's not overcomplicate things. Merging.

@mreiferson mreiferson merged commit 1444b10 into nsqio:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants