fix: update side-input readme #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 54 54
Lines 2167 2167
Branches 131 131
=======================================
Hits 2038 2038
Misses 97 97
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
we have to merge numaproj/helm-charts#14 first because the examples since are for 1.3/0.8 release. |
vigith
reviewed
Oct 15, 2024
| @@ -43,9 +43,28 @@ Side input spec: | |||
| ```yaml | |||
There was a problem hiding this comment.
Keep the original as is, and add ab example section
There was a problem hiding this comment.
The original spec example was incorrect, thus updating to these
There was a problem hiding this comment.
Or you mean removing the image values etc and just keeping the structure?
vigith
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kindly explain what this PR does.