Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update side-input readme #194

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: update side-input readme #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions examples/sideinput/simple_sideinput/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,28 @@ Side input spec:
```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the original as is, and add ab example section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original spec example was incorrect, thus updating to these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you mean removing the image values etc and just keeping the structure?

spec:
sideInputs:
- name: vertex
udf:
container:
....
sideInputs:
- myticker
- name: myticker
container:
image: "quay.io/numaio/numaflow-python/sideinput-example:stable"
imagePullPolicy: Always
trigger:
schedule: "*/2 * * * *"

```

Vertex spec for the UDF vertex:
```yaml
vertices:
.....
- name: si-log
udf:
container:
image: "quay.io/numaio/numaflow-python/udf-sideinput-example:stable"
imagePullPolicy: Always
containerTemplate:
env:
- name: NUMAFLOW_DEBUG
value: "true" # DO NOT forget the double quotes!!!
sideInputs:
- myticker
```
Loading