Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when parent directory does not exist #436

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Don't panic when parent directory does not exist #436

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f9634
don't panic whan parent directory is not exists
WindSoilder Jun 2, 2022
d8cc837
no need to check parent exists
WindSoilder Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/history/file_backed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ impl History for FileBackedHistory {
// The unwritten entries
let own_entries = self.entries.range(self.len_on_disk..);

let parent = fname.parent().expect("history path shouldn't be '/'");
if !parent.exists() {
std::fs::create_dir_all(parent)?;
}
WindSoilder marked this conversation as resolved.
Show resolved Hide resolved

let mut f_lock = fd_lock::RwLock::new(
OpenOptions::new()
.create(true)
Expand Down