Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXDRIVE-2860: Code Coverage #4354

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

NXDRIVE-2860: Code Coverage #4354

wants to merge 39 commits into from

Conversation

gitofanindya
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (117f9f5) 49.04% compared to head (86c7f33) 53.10%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4354      +/-   ##
==========================================
+ Coverage   49.04%   53.10%   +4.06%     
==========================================
  Files          94       94              
  Lines       15681    15681              
==========================================
+ Hits         7690     8327     +637     
+ Misses       7991     7354     -637
Flag Coverage Δ
functional 44.76% <ø> (+6.74%) ⬆️
integration 2.06% <ø> (ø)
unit 37.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sourcery-ai sourcery-ai bot mentioned this pull request Nov 23, 2023
Open
@gitofanindya
NXDRIVE-2860: Code Coverage - added 14 testcases in test_api.py
c18102b
@gitofanindya
NXDRIVE-2860: Code Coverage - fixed test_open_document
e638dfa
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_api.py
81da5ce
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_api.py 8/12
7ce2f23
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_api.py 8/12 - 2
bc97f77
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_api.py 12/12
5d4a8c3
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_api.py 12/12 - 2
8467af4
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
0d03278 
…13/12
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
75d3797 
…13/12 -- 2
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
cf5be71 
…13/12 -- 3
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
6a43599 
…13/12 -- 4
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2860-Code-Coverage branch 2 times, most recently from 5de2ac2 to 89902b3 Compare December 13, 2023 11:30
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2860-Code-Coverage branch from 89902b3 to fcd87de Compare December 13, 2023 11:44
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
61eb924 
…27/12 -- 1
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
9e2da5b 
…03/01 -- 1
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
0911d58 
…04/01 added old remote_client
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
e22ccfa 
…04/01 added old remote_client -002
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
173cd73 
…05/01 added old remote_client and fixed
@gitofanindya
NXDRIVE-2860: Code Coverage - added test cases to test_remote_client …
7c0e728 
…09/01
@gitofanindya
NXDRIVE-2860: Code Coverage - added 11 files from old functional - 10…
65d81ef 
…/01 --1
@gitofanindya
NXDRIVE-2860: Code Coverage - added all rumming test cases from old f…
326201d 
…unctional - 10/01 --1
@gitofanindya
NXDRIVE-2860: Code Coverage - removed old test cases - 11/01 --1
8869373
@gitofanindya
NXDRIVE-2860: Code Coverage - removed not working old test cases - 15…
f98bca1 
…/01 --1
@gitofanindya
NXDRIVE-2860: Code Coverage - removed not working old test cases - 15…
225b7a3 
…/01 --2
@gitofanindya
NXDRIVE-2860: Code Coverage - removed not working old test cases - 16…
689bd90 
…/01 --1
@gitofanindya
NXDRIVE-2860: Code Coverage - removed not working old test cases - 16…
6acd95b 
…/01 --2
@gitofanindya
NXDRIVE-2860: Code Coverage -- working local win - 31
223d6f8
@gitofanindya
NXDRIVE-2860: Code Coverage -- working local win - 31/01
4470f59
@gitofanindya
NXDRIVE-2860: Code Coverage -- working local win - 31/01 - fixed spell
2fcd3d8
@gitofanindya
Merge branch 'master' of https://github.com/nuxeo/nuxeo-drive into wip-…
f3b61a3 
…NXDRIVE-2860-Code-Coverage
@gitofanindya
NXDRIVE-2860: Code Coverage -- working local win - 31/01 - final test
7f77076
@gitofanindya
NXDRIVE-2860: Code Coverage -- working local win - 01/02 - final
40714d6
@gitofanindya
NXDRIVE-2860: Code Coverage --02/02 - final
0411ad6
@gitofanindya
Merge branch 'master' of https://github.com/nuxeo/nuxeo-drive into wip-…
dc030f3 
…NXDRIVE-2860-Code-Coverage
mr-shekhar
mr-shekhar requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update changes.md

mr-shekhar
mr-shekhar approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-shekhar mr-shekhar mr-shekhar approved these changes

@swetayadav1 swetayadav1 Awaiting requested review from swetayadav1

@poojadaine poojadaine Awaiting requested review from poojadaine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitofanindya @mr-shekhar