NXDRIVE-2860: Code Coverage (Sourcery refactored) #4356

sourcery-ai · 2023-11-23T11:09:33Z

Pull Request #4354 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXDRIVE-2860-Code-Coverage branch, then run:

git fetch origin sourcery/wip-NXDRIVE-2860-Code-Coverage
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

CLAassistant · 2023-11-23T11:09:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CLAassistant · 2023-11-23T11:09:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2023-11-23T11:11:35Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6acd95b) 53.18% compared to head (397a794) 52.95%.

Files	Patch %	Lines
nxdrive/engine/workers.py	0.00%	5 Missing ⚠️

Additional details and impacted files

@@                        Coverage Diff                         @@
##           wip-NXDRIVE-2860-Code-Coverage    #4356      +/-   ##
==================================================================
- Coverage                           53.18%   52.95%   -0.24%     
==================================================================
  Files                                  94       94              
  Lines                               15683    15682       -1     
==================================================================
- Hits                                 8341     8304      -37     
- Misses                               7342     7378      +36

Flag	Coverage Δ
functional	`44.65% <16.66%> (-0.22%)`	⬇️
integration	`2.06% <0.00%> (+<0.01%)`	⬆️
unit	`37.42% <16.66%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sourcery-ai · 2024-01-16T06:28:50Z

nxdrive/dao/utils.py

-        return bool(status[0] == "ok")
+        return status[0] == "ok"


Function is_healthy refactored with the following changes:

Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

sourcery-ai · 2024-01-16T06:28:50Z

nxdrive/engine/workers.py

-            try:
-                self._execute()
-            except ThreadInterrupt:
-                log.debug("Thread INTERRUPT")
-            except Exception:
-                log.exception("Thread EXCEPTION")
+            self._execute()
+        except ThreadInterrupt:
+            log.debug("Thread INTERRUPT")
+        except Exception:
+            log.exception("Thread EXCEPTION")


Function Worker.run refactored with the following changes:

Merge nested try-statement into a single try (flatten-nested-try)

sourcery-ai · 2024-01-16T06:28:50Z

tests/functional/conftest.py

-        input_obj = "doc:" + doc_path
+        input_obj = f"doc:{doc_path}"


Function TwoUsersTest._set_read_permission refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:50Z

tests/functional/conftest.py

-        input_obj = "doc:" + doc_path
+        input_obj = f"doc:{doc_path}"


Function TwoUsersTest.set_readonly refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_encoding.py

-        assert remote.get_info("/" + filename).name == filename
+        assert remote.get_info(f"/{filename}").name == filename


Function TestEncoding.test_name_normalization refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_remote_client.py

-        fs_item_id = FS_ITEM_ID_PREFIX + "fakeId"
+        fs_item_id = f"{FS_ITEM_ID_PREFIX}fakeId"


Function TestRemoteFileSystemClient.test_get_fs_info refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_remote_client.py

-            partial_descendants = scroll_res["descendants"]
-            if not partial_descendants:
+            if partial_descendants := scroll_res["descendants"]:
+                descendants.extend(partial_descendants)
+            else:
                break
-            descendants.extend(partial_descendants)


Function TestRemoteFileSystemClient.test_scroll_descendants refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Lift code into else after jump in control flow (reintroduce-else)

Swap if/else branches (swap-if-else-branches)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_remote_client.py

-        fs_item_id = FS_ITEM_ID_PREFIX + "fakeId"
+        fs_item_id = f"{FS_ITEM_ID_PREFIX}fakeId"


Function TestRemoteFileSystemClient.test_exists refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_remote_client.py

-        fs_item_id = FS_ITEM_ID_PREFIX + "fakeId"
+        fs_item_id = f"{FS_ITEM_ID_PREFIX}fakeId"


Function TestRemoteFileSystemClient.test_get_fs_item refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2024-01-16T06:28:51Z

tests/functional/test_watchers.py

-        total = len(self.make_server_tree())
-        # Add the workspace folder + the root
-        total += 2
+        total = len(self.make_server_tree()) + 2


Function TestWatchers.test_remote_scan refactored with the following changes:

Replace assignment and augmented assignment with single assignment (merge-assign-and-aug-assign)

This removes the following comments ( why? ):

# Add the workspace folder + the root

sourcery-ai bot requested a review from gitofanindya November 23, 2023 11:09

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch 2 times, most recently from a14c340 to a7f5b21 Compare November 23, 2023 11:10

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch 5 times, most recently from 7298f5d to c46c79b Compare December 8, 2023 05:44

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch 7 times, most recently from 0166544 to c2f689b Compare December 13, 2023 11:04

gitofanindya force-pushed the wip-NXDRIVE-2860-Code-Coverage branch from cc9967f to 5de2ac2 Compare December 13, 2023 11:20

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch from c2f689b to e6bf9dd Compare December 13, 2023 11:20

gitofanindya force-pushed the wip-NXDRIVE-2860-Code-Coverage branch from 5de2ac2 to 89902b3 Compare December 13, 2023 11:30

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch from e6bf9dd to 22092a6 Compare December 13, 2023 11:31

gitofanindya force-pushed the wip-NXDRIVE-2860-Code-Coverage branch from 89902b3 to fcd87de Compare December 13, 2023 11:44

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch from 22092a6 to c654de0 Compare December 13, 2023 11:44

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch from c654de0 to 69dd2ac Compare December 27, 2023 04:26

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch 5 times, most recently from 90e89a6 to 91c58c6 Compare January 9, 2024 06:26

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch 5 times, most recently from e3eba68 to 72d7aae Compare January 16, 2024 04:56

'Refactored by Sourcery'

397a794

sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2860-Code-Coverage branch from 72d7aae to 397a794 Compare January 16, 2024 06:28

sourcery-ai bot commented Jan 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NXDRIVE-2860: Code Coverage (Sourcery refactored) #4356

NXDRIVE-2860: Code Coverage (Sourcery refactored) #4356

sourcery-ai bot commented Nov 23, 2023 •

edited

Loading

CLAassistant commented Nov 23, 2023

CLAassistant commented Nov 23, 2023

codecov bot commented Nov 23, 2023 •

edited

Loading

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

sourcery-ai bot Jan 16, 2024

		assert remote.get_info("/" + filename).name == filename
		assert remote.get_info(f"/{filename}").name == filename

		fs_item_id = FS_ITEM_ID_PREFIX + "fakeId"
		fs_item_id = f"{FS_ITEM_ID_PREFIX}fakeId"

NXDRIVE-2860: Code Coverage (Sourcery refactored) #4356

Are you sure you want to change the base?

NXDRIVE-2860: Code Coverage (Sourcery refactored) #4356

Conversation

sourcery-ai bot commented Nov 23, 2023 • edited Loading

CLAassistant commented Nov 23, 2023

CLAassistant commented Nov 23, 2023

codecov bot commented Nov 23, 2023 • edited Loading

Codecov Report

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jan 16, 2024

Choose a reason for hiding this comment

sourcery-ai bot commented Nov 23, 2023 •

edited

Loading

codecov bot commented Nov 23, 2023 •

edited

Loading