This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
docs: Adding start script to node-server docs #5312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying to a service like Heroku, users will need to define a start script to avoid errors.
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @Chippd and thanks for this PR. For Heroku deployments (and generally other deployments as well), all we need is |
pi0
added
documentation
|
Fair enough, it did feel not-quite-right adding Heroku-specific config here but it should be somewhere, and I couldn't find it easily. |
|
Let's track in the upstream issue. Thanks for PR anyways <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying to a service like Heroku, users will need to define a start script to avoid errors.
🔗 Linked issue
❓ Type of change
📚 Description
When trying to deploy a nuxt app to heroku, I received an error that there was no start script. My change is to update the node server documentation to include this start script.
This improves the developer experience for Nuxt developers. This change makes it quicker for developers to get something deployed, reducing frustration and increasing satisfaction with Nuxt
📝 Checklist