Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve heroku preset #49

Closed
danielroe opened this issue Apr 8, 2022 · 2 comments
Closed

improve heroku preset #49

danielroe opened this issue Apr 8, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request preset proposal

Comments

@danielroe
Copy link
Member

danielroe commented Apr 8, 2022

heroku is very customisable but mostly this is done with buildpacks. Here's the node one.

By default the node buildpack will build, prune dev dependencies + package the entire app folder into a docker image. This is lots more space than Nitro needs. Options:

  1. create our own heroku buildpack
  2. create docker image (which can be shared with other platforms): docker preset #54

If you use the default heroku buildpack, you'll need to run heroku config:set HOST=0.0.0.0

@danielroe danielroe changed the title heroku [preset] heroku Apr 8, 2022
@danielroe danielroe added the enhancement New feature or request label Apr 8, 2022
@pi0 pi0 changed the title [preset] heroku heroku preset Apr 8, 2022
@danielroe danielroe self-assigned this Apr 13, 2022
@Hebilicious Hebilicious changed the title heroku preset imrove heroku preset Jun 30, 2023
@Hebilicious Hebilicious changed the title imrove heroku preset improve heroku preset Jun 30, 2023
@Hebilicious
Copy link
Member

@danielroe Can you confirm that this issue is still open to optimise the Heroku preset ?

@pi0
Copy link
Member

pi0 commented May 16, 2024

Considering it is an unattended issue for long time and we have a working preset, closing this tracker. docker support (#54) might allow improving Heroku preset too.

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
@pi0 pi0 mentioned this issue May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preset proposal
Projects
None yet
Development

No branches or pull requests

3 participants