Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add heroku deployment information #126

Merged
merged 3 commits into from
Apr 20, 2022
Merged

docs: add heroku deployment information #126

merged 3 commits into from
Apr 20, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

#49

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds some basic Heroku deployment information.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the documentation Improvements or additions to documentation label Apr 19, 2022
@danielroe danielroe requested a review from pi0 April 19, 2022 22:31
@danielroe danielroe self-assigned this Apr 19, 2022
pi0
pi0 reviewed Apr 20, 2022
View reviewed changes
docs/deploy/providers/heroku.md Outdated
1. Configure your app.

```bash
heroku config:set HOST=0.0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we could include it in default node server

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b7c7193

@pi0 pi0 merged commit 074193c into main Apr 20, 2022
@pi0 pi0 deleted the docs/heroku branch April 20, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0