Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend #8704

Merged
merged 1 commit into from
Nov 7, 2022
Merged

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend #8704

merged 1 commit into from
Nov 7, 2022

Conversation

MorevM
Copy link
Contributor

@MorevM MorevM commented Nov 4, 2022

πŸ”— Linked issue

I guess there is no need for issue since it's obvious.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Just worked on it and was surprised :)
Small mistake, but actually it is a breaking change since existed modules that uses render:html hook may use the key with a typo. Good thing it's still in RC stage :)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 4, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 39cc6ae
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63655ba9eca7370008439b3b

@atinux atinux requested a review from pi0 November 4, 2022 18:37
@manniL
Copy link
Member

manniL commented Nov 4, 2022

Good catch!
Maybe we could use a compat layer + warning for now though, so people have time to upgrade until the version after (or until stable)?

@MorevM
Copy link
Contributor Author

MorevM commented Nov 4, 2022

@manniL I don't think a compat layer makes sense, every next RC might include breaking changes, and users of edge channel are ready for that as well :)

@pi0 pi0 changed the title chore!: fix typo in NuxtRenderHTMLContext refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend Nov 7, 2022
@pi0 pi0 merged commit 7040d7a into nuxt:main Nov 7, 2022
@pi0
Copy link
Member

pi0 commented Nov 7, 2022

Thanks!

@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants