Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend #8712

Merged
merged 1 commit into from
Nov 7, 2022
Merged

refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend #8712

merged 1 commit into from
Nov 7, 2022

Conversation

agenordebriat
Copy link
Contributor

@agenordebriat agenordebriat commented Nov 4, 2022 •
edited
Loading

🔗 Linked issue

No issue.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Tried to use Nitro's render:html hook in a server plugin and noticed bodyPrepend was actually bodyPreprend.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 4, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 0132ecc
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63658b3e6e53bd0008eaaefc

@agenordebriat agenordebriat changed the title chore(nuxt): fix typo chore(nuxt)!: fix typo Nov 4, 2022
danielroe
danielroe approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@atinux atinux requested a review from pi0 November 5, 2022 09:45
@manniL
Copy link
Member

manniL commented Nov 5, 2022

We have 2 PRs fixing the same thing here - #8704

@pi0 pi0 changed the title chore(nuxt)!: fix typo refactor(nuxt)!: fix typo Nov 7, 2022
@pi0 pi0 changed the title refactor(nuxt)!: fix typo refactor(nuxt)!: fix typo for NuxtRenderHTMLContext.bodyPrepend Nov 7, 2022
@pi0 pi0 merged commit b60f136 into nuxt:main Nov 7, 2022
@pi0
Copy link
Member

pi0 commented Nov 7, 2022

Nice spot. Thanks!

@pi0
Copy link
Member

pi0 commented Nov 7, 2022

We have 2 PRs fixing the same thing here - #8704

Merged twice to keep credits :)

@pi0 pi0 mentioned this pull request Nov 15, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agenordebriat @manniL @pi0 @danielroe