Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update several existing tests #1273

Merged
merged 14 commits into from
Oct 18, 2023
Merged

Fix/update several existing tests #1273

merged 14 commits into from
Oct 18, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 16, 2023 •
edited
Loading

Description

  • Fix handling of union types in CLI
  • Fix handling of file paths in RSS source
  • Update tests to match recent code changes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner October 16, 2023 20:53
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components labels Oct 17, 2023
@dagardner-nv dagardner-nv mentioned this pull request Oct 17, 2023
Merged
@dagardner-nv dagardner-nv self-assigned this Oct 17, 2023
@dagardner-nv dagardner-nv mentioned this pull request Oct 18, 2023
Merged
mdemoret-nv
mdemoret-nv approved these changes Oct 18, 2023
View reviewed changes
morpheus/cli/register_stage.py Outdated Show resolved Hide resolved
morpheus/stages/input/rss_source_stage.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv merged commit 4149ec1 into nv-morpheus:fea-sherlock Oct 18, 2023
2 of 4 checks passed
@dagardner-nv dagardner-nv deleted the david-fea-sherlock-tests branch October 18, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv