Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates & fixes for the vdb_upload pipeline #1289

Merged
merged 11 commits into from
Oct 18, 2023
Merged

Misc updates & fixes for the vdb_upload pipeline #1289

merged 11 commits into from
Oct 18, 2023

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Add a minimal readme with triton command
  • Remove pre_calc_embeddings flag and make this enabled by default (pipe wasn't working without it)
  • Update model name and feature length size.
  • Add a --stop_after flag allowing the pipeline to be quickly tested
  • Fix stop_after functionality in RSS source stage
  • Add LLM dependencies to kitchen-sink examples yaml
  • Widen networkx version restriction to match requirements for langchain which is incompat with networkx 3.0+
  • Builds on/includes changes from PRs Fix/update several existing tests #1273 & Skip milvus tests by default #1284

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Add dependencies needed for llm examples to the examles yaml. Widen t…
580a4a1 
…he version of networkx to allow earlier versions to match version requirements for langchain
@dagardner-nv
Fix handling of stop_after feature
35f1035
@dagardner-nv
Add a stop-adter flag
81c3b72
@dagardner-nv
Merge branch 'fea-sherlock' of github.com:nv-morpheus/Morpheus into d…
020f44b 
…avid-fea-sherlock-integrations
@dagardner-nv
Update model name and feature length size.
e8213d9 
Remove pre_calc_embeddings flag and make this enabled by default.
Elevate the deserialize flag prior to the trigger when --isolate_embeddings is enabled.
Add a minimal readme
@dagardner-nv dagardner-nv requested review from a team as code owners October 18, 2023 16:07
@dagardner-nv dagardner-nv self-assigned this Oct 18, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 18, 2023
@dagardner-nv dagardner-nv merged commit deef181 into nv-morpheus:fea-sherlock Oct 18, 2023
1 of 4 checks passed
@dagardner-nv dagardner-nv deleted the david-fea-sherlock-integrations branch October 18, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv