UI Automation in Windows Console: Fix annoying focus repeating

[LeonarddeR]

Link to issue number:

None

Summary of the issue:

When starting an UIA console, speech output could go like this:

C:\WINDOWS\system32\cmd.exe  window
terminal
C:\Users\Leonard de Ruijter>
terminal
C:\Users\Leonard de Ruijter>
terminal
C:\Users\Leonard de Ruijter>

This is because the parent of the actual console window gets focus first and redirects its focus to the actual terminal. However, it looks like focus bounces back from parent to child around twice.

Description of how this pull request fixes the issue:

Don't let a consoleUIAWindow take focus if its focus redirect currently has focus. For this, we also cache the focus redirect.

Testing performed:

Tested that focus repeating does no longer occur.

Known issues with pull request:

None

Change log entry:

• Bug fixes
  • In UIA in Windows consoles, focus announcements are no longer repeated unnecessarily.

[LeonarddeR]

Ugh, it looks like this somehow worked for me, but it turns out that I made a mistake in the code that caused shouldAllowUIAFocusEvent to fail. I didn't get any logging about this, though.

[mohdshara]

I am confused here. did this ever get merged? this and #10030 isn't fixed as of today's build: alpha-19128,df0211c4

[LeonarddeR]

This wasn't merged at all, it was closed as the solution was invalid.

[mohdshara]

does this mean that #10030 should be re-opened? or should we file a new bug for this?