No longer repeat focusing UIA consoles #10531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10030
Another attempt that replaces #10180
Summary of the issue:
When focusing UIA consoles, the focus object is sometimes repeated.
Description of how this pull request fixes the issue:
The parent window of the terminal text area sometimes steals the focus. This was fixed by adding a focusRedirect to that window, but it look like that was actually the cause of repeating the focus. Therefore, I removed the focus redirect and used shouldAllowUIAFocusEvent instead to avoid this window stealing the focus.
Testing performed:
Started the UIA console several times, no focus repeating occurred.
I would like @codeofdusk to share his ideas about this pr, because it removes an assumption made by him.
Known issues with pull request:
None
Change log entry: