Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer repeat focusing UIA consoles #10531

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

Fixes #10030
Another attempt that replaces #10180

Summary of the issue:

When focusing UIA consoles, the focus object is sometimes repeated.

Description of how this pull request fixes the issue:

The parent window of the terminal text area sometimes steals the focus. This was fixed by adding a focusRedirect to that window, but it look like that was actually the cause of repeating the focus. Therefore, I removed the focus redirect and used shouldAllowUIAFocusEvent instead to avoid this window stealing the focus.

Testing performed:

Started the UIA console several times, no focus repeating occurred.
I would like @codeofdusk to share his ideas about this pr, because it removes an assumption made by him.

Known issues with pull request:

None

Change log entry:

@codeofdusk
Copy link
Contributor

I’ll test this shortly. No need for a changelog entry.

Copy link
Contributor

@codeofdusk codeofdusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully re-tested the "console focus" section of the UIA console test plan. Observed no duplicate announcements, focus loss, or erroneous selections.

@michaelDCurran michaelDCurran merged commit 30f4574 into nvaccess:master Nov 24, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repetition when focusing a console window
4 participants