Verify success of forward review moves by word and line

[codeofdusk]

Link to issue number:

Closes #12808.

Summary of the issue:

In Microsoft Word, new builds of Windows Console, and Edgium with UIA enabled, "bottom" is not reported when moving past the end of the document in review. These providers return nonzero when moving collapsed textInfos forward past the end, but simply set them to the exclusive end of the document.

Description of how this pull request fixes the issue:

When moving forward by word or line, maintain the old position and verify that the new position is after the previous.

Testing strategy:

Tested in affected modern providers, notepad with MSAA, Chrome with IA2, and the MS Word object model.

Known issues with pull request:

None known.

Change log entries:

== Bug Fixes ==

• When moving the review cursor past the end of text controls, such as in Microsoft Word with UI Automation, "bottom" is correctly reported in more situations. (Some UIA text ranges have no apparent bottom #12808)

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English

[michaelDCurran]

"...but simply set them to POSITION_LAST (i.e. collapsed at the very end of the document)."
This statement is not correct. NVDA's POSITION_LAST represents the start of the last character, not the (exclusive) end of the content/document.
However, the intention of the description is accurate, so just remove any mention of POSITION_LAST.

[codeofdusk]

Description updated.

[seanbudd]

Thanks @codeofdusk - I've left some minor fixes for the comments.

Tested in affected modern providers.

Have you tested these commands in other scenarios (eg not UIA)?

was meant to be a comment not an approval

[codeofdusk]

Have you tested these commands in other scenarios (eg not UIA)?

Yes, tested in Notepad with MSAA.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests. See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/x676sr2rnl3223wj/artifacts/output/nvda_snapshot_pr12960-24043,3c564a66.exe

See test results for failed build of commit 3c564a6699