Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify success of forward review moves by word and line #12960

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Verify success of forward review moves by word and line #12960

merged 5 commits into from
Oct 21, 2021

Commits on Oct 19, 2021

  1. review_nextLine script: even if move by line succeeds, double check t… 

    …hat the new line does in deed start after the original review cursor position. Otherwise, we have hit the bottom.
    @michaelDCurran @codeofdusk
    michaelDCurran authored and codeofdusk committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    5bbf2e9 View commit details
    Browse the repository at this point in the history

  2. Cleanup and apply fix to next word script as well.

    @codeofdusk
    codeofdusk committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    d9741c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Sean Budd <seanbudd123@gmail.com>
    @codeofdusk @seanbudd
    codeofdusk and seanbudd authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0a712b0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into t12808v3

    @seanbudd
    seanbudd committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    cefac5e View commit details
    Browse the repository at this point in the history

  3. update changes

    @seanbudd
    seanbudd committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    8f32b31 View commit details
    Browse the repository at this point in the history