Ability to set the description for nwdirectory in "Browse for Folder" dialog

[ghost]

I am using nwdirectory attribute to an input="file" field in order to trigger the "Browse for Folder" dialog. However the description on the dialog is misleading, I don't want to "upload" a folder, but rather choose a folder. It can also give a wrong impression to the user, that you are actually going to upload his, often private, files somewhere.

Could we have an extra attribute nwdirectorydesc that would allow us to set that description? Like so,

<input id="folder-open-dialog" type="file" style="display: none;" nwdirectory nwworkingdir="" nwdirectorydesc="Please select a folder" role="hidden" />

[motla]

+1

[octachrome]

@rogerwang I considered trying to fix this, but after looking through the source code I'm confused about why the message reads "Select Folder to Upload".

• I checked out nwjs/chromium.src and looked for the string "Select Folder to Upload" - it only occurs as part of the label IDS_SELECT_UPLOAD_FOLDER_DIALOG_TITLE.
• I looked for usages of the label - it is only used when the file select helper is opened with dialog type set to SELECT_UPLOAD_FOLDER.
• I checked the nwjs/nw.js source, and SELECT_UPLOAD_FOLDER is never used - NW.js only uses SELECT_FOLDER, which should result in the label IDS_SELECT_FOLDER_DIALOG_TITLE being used instead, which reads "Select Folder".

Do you have any idea how/why the "Select Folder to Upload" label is being used?

I am using branch nw22.

[rogerwang]

Thanks. You can check the following files:
ui/shell_dialogs/select_file_dialog_win.cc
chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc
chrome/browser/ui/libgtkui/select_file_dialog_impl_kde.cc

[octachrome]

@rogerwang The reason I was confused is because I was assuming that nw.js/src/browser/file_select_helper.cc was used instead of chromium.src/chrome/src/browser/file_select_helper.cc. However, debugging shows that this is not the case. The version of RunFileChooserOnUIThread in NW.js passes SELECT_FOLDER as expected, whereas the Chromium version of RunFileChooserOnUIThread passes SELECT_UPLOAD_FOLDER. The Chromium version of the function is being invoked, so the wrong message is being displayed.

What is the relationship between these two source files?

[octachrome]

@rogerwang Can you shed any light on this?

[rogerwang]

The source files in the NW repo was for pre-0.13 and should be removed.

…

On Mon, May 15, 2017, 10:52 PM Chris Brown ***@***.***> wrote: @rogerwang <https://github.com/rogerwang> Can you shed any light on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKGGUBUJa8gzNnJRqhN8f4UoYBFU7ksks5r6GawgaJpZM4J0YKD> .

[octachrome]

@rogerwang OK. I propose reapplying the following change to chrome/browser/file_select_helper.cc:

-      dialog_type_ = ui::SelectFileDialog::SELECT_UPLOAD_FOLDER;
+      dialog_type_ = ui::SelectFileDialog::SELECT_FOLDER;

As originally committed in c5ef962.

I can do a pull request, but I'm not sure which branch to fork. I can see that chromium.src/nw22 has the entire NW.js changeset squashed and rebased onto it, so I'm guessing a pull request onto that branch would not be useful to you...

[octachrome]

@rogerwang What do you think of my suggestion?

[octachrome]

@rogerwang Do you (or someone else) have time to look at my suggestion? I am very happy to spend time working on this issue if it helps to resolve it, but I need some feedback :)

[rogerwang]

Sure, will look to fix it with your patch.

[Pabloandumundu]

In nw.js version 0.23.6 for windows still appear "Select Folder to Upload". That message is very horrible when you create an application where files are handled locally.

[charlielee]

@octachrome @rogerwang I was wondering what the status of this issue/bug is. It is still present in v0.26+. Many thanks :)

[octachrome]

@rogerwang I would also like to know the status of this. It seems like a really simple fix, unless there is something I don't understand about it, but it has been many months and many posts to this thread and it is still not resolved.

Is there some way we can help with this? By creating a pull request? Or something else?

[rogerwang]

Will see it soon. Thanks.

…

On Dec 31, 2017 6:01 PM, "Chris Brown" ***@***.***> wrote: @rogerwang <https://github.com/rogerwang> I would also like to know the status of this. It seems like a really simple fix, unless there is something I don't understand about it, but it has been many months and many posts to this thread and it is still not resolved. Is there some way we can help with this? By creating a pull request? Or something else? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKGGV5rpETRU5Zhf_GjEWwUl1ewJeH9ks5tF1uAgaJpZM4J0YKD> .

[rogerwang]

Just fixed this in nw28 branch. Added nwdirectorydesc as proposed and changed the default string to Select Folder. It will be available in the next 0.28.0-rc1 build.

[octachrome]

Thanks, really appreciated!

[rogerwang]

Please try it: https://dl.nwjs.io/live-build/01-04-2018/nw28-f7b3808-0581a4d-e3aa6ab-1b41f4f/v0.28.0-rc1/

[octachrome]

@rogerwang I have updated to 0.28 and this works perfectly now. Many thanks!