Upload button instead of select on folder picker nwdirectory

[gpetrov]

NWJS Version : 0.30.2
Operating System : Only Windows 10 64 bit
On Mac OSX this is working fine

Expected behavior

Open System Select Folder dialog with "Select" button and "Create Folder" buttons

Actual behavior

Select Folder dialog shows wrong button "Upload" instead of "Select" and is also missing the Create Folder" button

How to reproduce

<input id="folder-open-dialog" type="file" nwdirectory nwworkingdir="" nwdirectorydesc="Please select a folder" role="hidden" />

Sorry for the localized dutch screenshot - but it should be clear 😄

Maybe related to:
#5265

Test files:
folder_picker_bug.zip

[Christywl]

I can reproduce this issue on Windows with nwjs-sdk-v0.30.3:

nwjs-sdk-v0.28.3

It works fine on Linux and Mac .

[gpetrov]

@rogerwang could you please check this? is a simple enum to fix. I will hate to go back to 0.28.3 for just this simple folder picker ... but it is very confusing to our users.

[rogerwang]

Will see it soon.

…

On Mon, May 14, 2018, 10:44 PM George Petrov ***@***.***> wrote: @rogerwang <https://github.com/rogerwang> could you please check this? is a simple enum to fix. I will hate to go back to 0.28.3 for just this simple folder picker ... but it is very confusing to our users. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKGGYc-Tn1ZtUPikuoxpD7E7gf8ZZvhks5tyZhcgaJpZM4T6aeL> .

[rogerwang]

This is fixed in git and will be available in the next nightly build.

[premalatha-bv]

Issue still exists with 0.37.0 version too.
If it is fixed in 0.30.0 version. Could you please move the changes to 0.37.0 version too.

Am facing same issue with 0.37.0 version.

[ffanny]

I can reproduce this with nwjs-sdk-win-v0.36.0&v0.37.0. It works well with v0.35.5.

[rogerwang]

Thanks.

@ffanny we should find a way to add this to automatic tests.

[ffanny]

Thanks.

@ffanny we should find a way to add this to automatic tests.

Will try to add autotest soon.

[premalatha-bv]

Please let us know, If this changes has been added in 0.37.0 version? or any new version released for same changes? It would be very helpful for us to decide, whether we need to change to older version or continue with latest version.

[rogerwang]

It will be fixed on 0.37 branch and released with 0.37.2 soon.

[rogerwang]

This is fixed in git and will be available in the next nightly build.

[rogerwang]

The fix was built here: https://dl.nwjs.io/live-build/nw37/04-01-2019/8a1cce4ef/v0.37.2/