Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NW crash when debugging with developer tools #5882

Closed
Shawyeok opened this issue Apr 27, 2017 · 4 comments
Closed

NW crash when debugging with developer tools #5882

Shawyeok opened this issue Apr 27, 2017 · 4 comments
Assignees
@rogerwang
Labels
bug P1 triaged

Comments

@Shawyeok
Copy link

Shawyeok commented Apr 27, 2017 •
edited
Loading

Example code(index.html):

<!DOCTYPE html>
<html>
  <head>
    <title>Hello World!</title>
  </head>
  <body>
    <h1>Hello World!</h1>
    We are using node.js <script>document.write(process.version)</script>.
    <script type="text/javascript">
      var request = require('request');
      setInterval(function() {
        request({
          url: 'http://www.bing.com',
          method: 'get'
        }, function(err, response, body) {
          if (err) return console.error(err.stack);    // line 16

          console.log(response, body);
        });
      }, 3 * 1000);
    </script>
  </body>
</html>

Open developer tools in the page above, add a breakpoint on line 16, NW will crash after click Resume script execution button second time.

Crash dump: a9b42631-02f5-4f9b-a0cb-80bbb4675faa.zip

@xianlong1226

/cc @fujunwei @xzhan96 @rogerwang
@Shawyeok
Copy link
Author

Shawyeok commented Apr 27, 2017 •
edited
Loading

My environment:

nw.js v0.21.2
Node v7.7.3
Chromium 57.0.2987.98
commit hash: 6388aaa-d7e4cbf-96303a2-d7e4cbf
OS: MacOS 10.12.4

@rogerwang rogerwang self-assigned this Apr 28, 2017
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@Shawyeok
Copy link
Author

Can you please refer your commit that fix this bug?

@rogerwang
Copy link
Member

nwjs/chromium.src@f4bd6d4

This was referenced Dec 22, 2017
Closed
Closed
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 18, 2018
@wanghongjuan
[test] Add test case for issue nwjs#5882
452772e 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
@wanghongjuan wanghongjuan mentioned this issue Jan 18, 2018
Merged
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Feb 6, 2018
@wanghongjuan
[test] Add test case for issue nwjs#5882
a95d719 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Feb 6, 2018
@wanghongjuan
[test] Add test case for issue nwjs#5882
bb7eff2 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Feb 6, 2018
@wanghongjuan
[test] Add test case for issue nwjs#5882
2308d35 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Feb 6, 2018
@wanghongjuan
[test] Add test case for issue nwjs#5882
bd69514 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
rogerwang pushed a commit that referenced this issue Feb 8, 2018
@wanghongjuan @rogerwang
[test] Add test case for issue #5882
115eaf2 
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
bug P1 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogerwang @Shawyeok @wanghongjuan