[test] Add test case for issue #5882 #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wanghongjuan
commented
Jan 18, 2018
•
wanghongjuan
commented
- Add test for issue NW crash when debugging with developer tools #5882
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
rogerwang
requested changes
Feb 5, 2018
| if platform.system() == "Windows": | ||
| subprocess.call(["npm", "install", "request"], shell=True) | ||
| else: | ||
| subprocess.call(["npm", "install", "request"]) |
There was a problem hiding this comment.
should use the util function to install the module.
wanghongjuan
force-pushed
the
issue5882-add-test
branch
4 times, most recently
from
2308d35 to
bd69514
Compare
- This case is failed on failed version 0.21.2, pass on fixed version 0.27.4
rogerwang
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.