-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change script source type and compiler api to improve code. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…wjs#1 id:1 of https://codereview.chromium.org/1014263002/) Reason for revert: It seems to cause crbug/469146. Original issue's description: > Allow compaction when incremental marking is on. > > BUG=chromium:450824 > LOG=NO > > Committed: https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 > Cr-Commit-Position: refs/heads/master@{#27267} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:450824 Review URL: https://codereview.chromium.org/1026813002 Cr-Commit-Position: refs/heads/master@{#27345}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…ps://codereview.chromium.org/1035643002/) Reason for revert: Crash in pdfjs benchmark. Original issue's description: > [turbofan] Enable --turbo-osr. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/50305aac39f90b6455305313db56ff3365ec96f5 > Cr-Commit-Position: refs/heads/master@{#27431} TBR=titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1005163003 Cr-Commit-Position: refs/heads/master@{#27432}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…etting script break points. (patchset nwjs#1 id:1 of https://codereview.chromium.org/999273003/) Reason for revert: Reland since the failure has been fixed in https://codereview.chromium.org/1035523005/ Original issue's description: > Revert of Debugger: deduplicate shared function info when setting script break points. (patchset nwjs#4 id:60001 of https://codereview.chromium.org/998253005/) > > Reason for revert: > Code caching failures. > > Original issue's description: > > Debugger: deduplicate shared function info when setting script break points. > > > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > > > BUG=v8:3960 > > LOG=N > > > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > > Cr-Commit-Position: refs/heads/master@{#27444} > > TBR=mstarzinger@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3960 > > Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b > Cr-Commit-Position: refs/heads/master@{#27448} TBR=mstarzinger@chromium.org BUG=v8:3960 LOG=N Review URL: https://codereview.chromium.org/1037013002 Cr-Commit-Position: refs/heads/master@{#27472}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…alid entries from the SlotsBuffer. (patchset nwjs#1 id:1 of https://codereview.chromium.org/1020853022/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. > > BUG=chromium:470801 > LOG=Y > > Committed: https://crrev.com/2f3a42f9a1d66ffc9d260d9700ff831c3aa1cd41 > Cr-Commit-Position: refs/heads/master@{#27467} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470801 Review URL: https://codereview.chromium.org/1033163002 Cr-Commit-Position: refs/heads/master@{#27490}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…nwjs#1 id:1 of https://codereview.chromium.org/1013743006/) Reason for revert: Revert due to crash. Original issue's description: > [turbofan][arm64] Match fneg for -0.0 - x pattern. > > Note that this patch add an extra bit to the ArchOpcodeField. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/fe7441225100660d01e66ce3bcaefe368f62df81 > Cr-Commit-Position: refs/heads/master@{#27494} TBR=bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1041633002 Cr-Commit-Position: refs/heads/master@{#27495}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…nwjs#1 id:1 of https://codereview.chromium.org/1045763002/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Relax assert a little to fix flake on regress-3976 > > R=verwaest@chromium.org > NOTRY=true > BUG= > > Committed: https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 > Cr-Commit-Position: refs/heads/master@{#27515} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1050033003 Cr-Commit-Position: refs/heads/master@{#27561}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 9, 2015
…:1 of https://codereview.chromium.org/1043363005/) Reason for revert: breaks some devtools things Original issue's description: > make ToLocalCheck crash in release mode > > R=svenpanne@chromium.org > BUG= > > Committed: https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94 > Cr-Commit-Position: refs/heads/master@{#27585} TBR=svenpanne@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1057873003 Cr-Commit-Position: refs/heads/master@{#27589}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 15, 2015
…set nwjs#1 id:1 of https://codereview.chromium.org/1050443002/) Reason for revert: this indeed drops the max major gc time considerable, so turn it back on Original issue's description: > Turn off overapproximation of the weak closure again > > As long as we still have to process global handles, the impact is not > yet worthwhile > > BUG=v8:3862 > R=hpayer@chromium.org > LOG=y > > Committed: https://crrev.com/294cdc6aecbd7f76be68217da4b3d35901ebce4b > Cr-Commit-Position: refs/heads/master@{#27570} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3862 Review URL: https://codereview.chromium.org/1068723003 Cr-Commit-Position: refs/heads/master@{#27616}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 15, 2015
id:1 of https://codereview.chromium.org/966653002/) Reason for revert: speculative revert due to gc-stress timeouts. Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > Cr-Commit-Position: refs/heads/master@{#27619} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:3608 LOG=N Review URL: https://codereview.chromium.org/1063383004 Cr-Commit-Position: refs/heads/master@{#27654}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 15, 2015
…. (patchset nwjs#1 id:1 of https://codereview.chromium.org/1070653002/) Reason for revert: ARM test failure, need to investigate. Original issue's description: > VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. > > R=verwaest@chromium.org > BUG= > > Committed: https://crrev.com/2395eda3bb7aca938751938df76e01ac2b89b0a6 > Cr-Commit-Position: refs/heads/master@{#27657} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1072463002 Cr-Commit-Position: refs/heads/master@{#27664}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 15, 2015
https://codereview.chromium.org/1066373002/) Reason for revert: Reverting as it resulted in a closed waterfall. Original issue's description: > X87: Reimplement Maps and Sets in JS > > port 909500a (r27605) > > original commit message: > Previously, the only optimized code path for Maps and Sets was for String keys. > This was achieved through an implementation of various complex operations > in Hydrogen. This approach was neither scalable nor forward-compatible. > > This patch adds the necessary intrinsics to implement Maps and Sets almost entirely > in JS. The added intrinsics are: > > %_FixedArrayGet > %_FixedArraySet > %_TheHole > %_JSCollectionGetTable > %_StringGetRawHashField > > With these additions, as well as a few changes to what's exposed as runtime functions, > most of the C++ code backing Maps and Sets is gone (including both runtime code in > objects.cc and Crankshaft in hydrogen.cc). > > BUG= > > Committed: https://crrev.com/56600a35a49ffa5abcba66b14839089de3589ad9 > Cr-Commit-Position: refs/heads/master@{#27681} TBR=weiliang.lin@intel.com,chunyang.dai@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1073723002 Cr-Commit-Position: refs/heads/master@{#27682}
liyingzh
pushed a commit
to liyingzh/v8
that referenced
this pull request
Apr 15, 2015
…js#1 id:1 of https://codereview.chromium.org/1073723002/) Reason for revert: Revert the revert as this commit cannot be the cause for the closed tree. Original issue's description: > Revert of X87: Reimplement Maps and Sets in JS (patchset nwjs#1 id:1 of https://codereview.chromium.org/1066373002/) > > Reason for revert: > Reverting as it resulted in a closed waterfall. > > Original issue's description: > > X87: Reimplement Maps and Sets in JS > > > > port 909500a (r27605) > > > > original commit message: > > Previously, the only optimized code path for Maps and Sets was for String keys. > > This was achieved through an implementation of various complex operations > > in Hydrogen. This approach was neither scalable nor forward-compatible. > > > > This patch adds the necessary intrinsics to implement Maps and Sets almost entirely > > in JS. The added intrinsics are: > > > > %_FixedArrayGet > > %_FixedArraySet > > %_TheHole > > %_JSCollectionGetTable > > %_StringGetRawHashField > > > > With these additions, as well as a few changes to what's exposed as runtime functions, > > most of the C++ code backing Maps and Sets is gone (including both runtime code in > > objects.cc and Crankshaft in hydrogen.cc). > > > > BUG= > > > > Committed: https://crrev.com/56600a35a49ffa5abcba66b14839089de3589ad9 > > Cr-Commit-Position: refs/heads/master@{#27681} > > TBR=weiliang.lin@intel.com,chunyang.dai@intel.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/a0486f128109443ed07802fb463c267e53533d81 > Cr-Commit-Position: refs/heads/master@{#27682} TBR=weiliang.lin@intel.com,chunyang.dai@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1077543002 Cr-Commit-Position: refs/heads/master@{#27685}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…id:1 of https://codereview.chromium.org/1082703003/) Reason for revert: [Sheriff] Flaky nosnap failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 Original issue's description: > Wrap typed array implementations in functions. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > Cr-Commit-Position: refs/heads/master@{#27784} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1086683002 Cr-Commit-Position: refs/heads/master@{#27789}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…atchset #1 id:1 of https://codereview.chromium.org/1086683002/) Reason for revert: I don't think this is the cause. Original issue's description: > Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1082703003/) > > Reason for revert: > [Sheriff] Flaky nosnap failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 > > Original issue's description: > > Wrap typed array implementations in functions. > > > > R=mvstanton@chromium.org > > > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > > Cr-Commit-Position: refs/heads/master@{#27784} > > TBR=mvstanton@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/8e3fa7adf20f4f9c9125076a878d601eee7c9f35 > Cr-Commit-Position: refs/heads/master@{#27789} TBR=mvstanton@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1083013002 Cr-Commit-Position: refs/heads/master@{#27803}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…ctions. (patchset #1 id:1 of https://codereview.chromium.org/1083013002/) Reason for revert: Seems to still break those tests. Original issue's description: > Revert of Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1086683002/) > > Reason for revert: > I don't think this is the cause. > > Original issue's description: > > Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1082703003/) > > > > Reason for revert: > > [Sheriff] Flaky nosnap failures: > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 > > > > Original issue's description: > > > Wrap typed array implementations in functions. > > > > > > R=mvstanton@chromium.org > > > > > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > > > Cr-Commit-Position: refs/heads/master@{#27784} > > > > TBR=mvstanton@chromium.org,yangguo@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://crrev.com/8e3fa7adf20f4f9c9125076a878d601eee7c9f35 > > Cr-Commit-Position: refs/heads/master@{#27789} > > TBR=mvstanton@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/d7fe3b83f5dfa997f0c8a29436a22b999dc49a76 > Cr-Commit-Position: refs/heads/master@{#27803} TBR=mvstanton@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1088863002 Cr-Commit-Position: refs/heads/master@{#27810}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…chset #1 id:1 of https://codereview.chromium.org/1059853004/) Reason for revert: still times out Original issue's description: > Reland "Remove support for thread-based recompilation" > > Original issue's description: > > Remove support for thread-based recompilation > > > > BUG=v8:3608 > > R=yangguo@chromium.org > > LOG=y > > > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > > Cr-Commit-Position: refs/heads/master@{#27619} > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/f1ceccb8b8b352a91e6366e3e3103f1db0df6afb > Cr-Commit-Position: refs/heads/master@{#27813} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Review URL: https://codereview.chromium.org/1082183003 Cr-Commit-Position: refs/heads/master@{#27816}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…https://codereview.chromium.org/1085153002/) Reason for revert: Seems to cause performance regressions. Original issue's description: > [x64] Use xorl to materialize smi zero. > > Before we always loaded smi zero via a movabs with a 64-bit immediate, > which is pretty expensive compared to the xorl. > > R=jarin@chromium.org > > Committed: https://crrev.com/f236777bfe6e080ff1ead6baf847cc9b6bb4f9cb > Cr-Commit-Position: refs/heads/master@{#27829} TBR=jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:477592 LOG=n Review URL: https://codereview.chromium.org/1059543004 Cr-Commit-Position: refs/heads/master@{#27867}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…//codereview.chromium.org/1086313003/) Reason for revert: [Sheriff]: This changes layout test expectations e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964 Original issue's description: > Migrate error messages, part 2. > > Motivation for this is reducing the size of the native context. > > Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65 > Cr-Commit-Position: refs/heads/master@{#27878} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1095573002 Cr-Commit-Position: refs/heads/master@{#27889}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…te chrasher." (patchset #1 id:1 of https://codereview.chromium.org/1080303002/) Reason for revert: Still doesn't work Original issue's description: > Revert "Remove early bail-out in VisitWeakList to investigate chrasher." > > > BUG=468601 > > LOG=n > > > > Review URL: https://codereview.chromium.org/1016353002 > > > > Cr-Commit-Position: refs/heads/master@{#27317} > > R=hpayer@chromium.org > BUG=v8:3996,chromium:468601 > LOG=n > > Committed: https://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef > Cr-Commit-Position: refs/heads/master@{#27814} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996,chromium:468601 Review URL: https://codereview.chromium.org/1092783002 Cr-Commit-Position: refs/heads/master@{#27902}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
id:1 of https://codereview.chromium.org/1084793004/) Reason for revert: breaks mjsunit on debug bots Original issue's description: > LayoutDescriptor should inherit from JSTypedArray > > It can't just inherit from a FixedTypedArray-like type, as we soon > assume that a FixedTypedArray-like type is always held by an > ArrayBufferView-like type > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n TBR=ishell@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1073053006 Cr-Commit-Position: refs/heads/master@{#27968}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…eview.chromium.org/1083923005/) Reason for revert: Needed to revert https://chromium.googlesource.com/v8/v8/+/7bcc3d10835105fadc8ecf42a877dec479f0f80d Original issue's description: > fix bad rebase in r27966 > > TBR=verwaest@chromium.org > > BUG= TBR=verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1093043003 Cr-Commit-Position: refs/heads/master@{#27981}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…chset #1 id:1 of https://codereview.chromium.org/1084183004/) Reason for revert: Check if this CL fails independently of https://chromium.googlesource.com/v8/v8/+/580d66bcda66220d2f3062ac58daf925436df74c Original issue's description: > Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) > > Reason for revert: > [Sheriff] This causes test failures on mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 > > Original issue's description: > > [es6] implement Array.prototype.copyWithin() > > > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > > > BUG=v8:4039 > > R=adamk@chromium.org > > LOG=N > > TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4039 > > Committed: https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 > Cr-Commit-Position: refs/heads/master@{#27984} TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Review URL: https://codereview.chromium.org/1072193005 Cr-Commit-Position: refs/heads/master@{#27997}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…eeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) > > Reason for revert: > [Sheriff] breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 > > Original issue's description: > > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > > > BUG=v8:3965, v8:3966 > > R=arv@chromium.org > > LOG=N > > > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > > Cr-Commit-Position: refs/heads/master@{#27985} > > TBR=arv@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3965, v8:3966 TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Review URL: https://codereview.chromium.org/1098243002 Cr-Commit-Position: refs/heads/master@{#27999}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
… with a PropertyCell. (patchset #1 id:1 of https://codereview.chromium.org/1099203004/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/1092043002/) > > Reason for revert: > MAC GCSTRESS failure on new test. > > Original issue's description: > > Protect the emptiness of Array prototype elements with a PropertyCell. > > > > Not just emptiness, but also a particular structure. > > > > BUG=v8:4044 > > LOG=N > > TBR=jkummerow@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4044 TBR=jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4044 Review URL: https://codereview.chromium.org/1052253003 Cr-Commit-Position: refs/heads/master@{#28000}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
… (patchset #1 id:1 of https://codereview.chromium.org/1105453002/) Reason for revert: Was an infrastructure problem. Original issue's description: > Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/1024063002/) > > Reason for revert: > [Sheriff] Breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024 > > Original issue's description: > > [strong] checking of this & super in constructors > > > > R=dslomov@chromium.org, marja@chromium.org > > BUG=v8:3956 > > LOG=N > > > > Enforces for constructors that > > - the only use of 'super' is the super constructor call > > - the only use of 'this' is a property assignment > > - both of these must happen at the top-level of the body > > - 'this' may only be assigned after the 'super' call > > - 'return' may only be used after the last assignment to 'this' > > > > Not yet working for arrow functions (there might be deeper bugs with those). > > > > Committed: https://crrev.com/580d66bcda66220d2f3062ac58daf925436df74c > > Cr-Commit-Position: refs/heads/master@{#27977} > > TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3956 TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1073103004 Cr-Commit-Position: refs/heads/master@{#28001}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…atchset #1 id:1 of https://codereview.chromium.org/1094383004/) Reason for revert: GC stress failure (custom snapshot) Original issue's description: > Always optimize for adding properties to native objects. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 > Cr-Commit-Position: refs/heads/master@{#28003} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1098223004 Cr-Commit-Position: refs/heads/master@{#28009}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…bjects. (patchset #1 id:1 of https://codereview.chromium.org/1098223004/) Reason for revert: Test failure was not due to this. Original issue's description: > Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/1094383004/) > > Reason for revert: > GC stress failure (custom snapshot) > > Original issue's description: > > Always optimize for adding properties to native objects. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 > > Cr-Commit-Position: refs/heads/master@{#28003} > > TBR=jkummerow@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/bb6958ceff221e66adbc4581471a8ce1b41a4684 > Cr-Commit-Position: refs/heads/master@{#28009} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1100123002 Cr-Commit-Position: refs/heads/master@{#28011}
rogerwang
pushed a commit
that referenced
this pull request
Jul 13, 2015
…ttps://codereview.chromium.org/1104073002/) Reason for revert: Reland after switching bot to ninja. Original issue's description: > Revert of [test] Make msan work for v8 stand-alone. (patchset #6 id:100001 of https://codereview.chromium.org/802583003/) > > Reason for revert: > Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047 > > Original issue's description: > > [test] Make msan work for v8 stand-alone. > > > > The msan configuration can be used in combination with > > v8_use_snapshot=false. > > > > BUG=chromium:425187 > > LOG=n > > > > Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 > > Cr-Commit-Position: refs/heads/master@{#28064} > > TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:425187 > > Committed: https://crrev.com/f69a48696ec3ec0ea1169a41b4c84fb36b059968 > Cr-Commit-Position: refs/heads/master@{#28068} TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:425187 Review URL: https://codereview.chromium.org/1102323002 Cr-Commit-Position: refs/heads/master@{#28078}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Performance and stability improvements on all platforms. TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ie6d2a1031a0bcc47f37f3f2f7e687bce4a88301d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572206 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=machenbach@chromium.org Change-Id: I87679639bb75212f57f668e0ca1c78c91a33a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571609 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#1} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Bug=chromium:318206 TBR=machenbach@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: Ib28c17e0d08985813b0ba8136fb747714e80a599 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571611 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#2} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I51fb2ea2dd2ca0c52ef7b1bf8a0bc03fc2437eb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572684 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#3} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Revision: f434acc458db917a909881461c203db1303f2622 BUG=v8:9147 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jarin@chromium.org Change-Id: I4f23480624c06f05c6d54b7760747b7ad22b6d2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583764 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#4} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic518d6a5b55ab183c7165ff13277fdb588f88b8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585525 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#5} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Merged: Put sealed, frozen elements kind behind flag Revision: 1377cd37ab44854a592801a04143bc4353b1dd58 Merged: Fix array.includes(NaN) for sealed/frozen packed element Revision: f8af2b7581ac41dccb05e29d94816771f7e88878 BUG=chromium:953888,v8:6831 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org Change-Id: I72152094122aa940cccb9353415fc45555a74373 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587383 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#6} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Id5495836e639ff13e3e65253861d2e9c7f10fedc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1586843 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#7} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
…rays. Revision: d2bfdafe200f4d100fc2ffbf5d6b5d1a542bf1f7 BUG=chromium:952586 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=neis@chromium.org Change-Id: I2cd0e656a0720be737574f0b4d748cad40c84b2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587380 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#8} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iaa9f29f9afd28b597f5f54fd6bd8805ee0132f4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587144 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#9} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
For a few double value above the max float, we have to round down to that max float rather than rounding up to infinity. (cherry picked from commit 7265ea973cffa84c9ed43c242fc3f58d7a69bed3) Bug: chromium:956564 Change-Id: I34be1def5330bd4c3352b792d20dd500f108d9e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585852 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#61052} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588458 Cr-Commit-Position: refs/branch-heads/7.5@{#10} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ib25930ee97effc42f122759cc5359978e2839a54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588157 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#11} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Merged: [wasm] Try to avoid LTO bug on arm Revision: 241294fe186c126cfcc3d9bf99023b808daf7701 Merged: cpu-arm: Add noinline to cache flushing logic Revision: e0e36ba0791624db71b92ee1bcaa3d02b6c0ab01 BUG=chromium:952759 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jkummerow@chromium.org Change-Id: I15357d13a9609c1b82fa1108330b36c4bd7a95fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588463 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#12} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I36536b60df4c20d82f4397ad8b381e68affe0ca2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588733 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#13} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
Revision: a474dbce7e8756ca9e8e6c6141c3853e9a610532 BUG=chromium:956426 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org Change-Id: Iac33264535ece91f572de266c56ea4dc39e29b45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588462 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#14} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 7, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I25ba47df139733d671ddc537b0638189f3b709fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588734 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#15} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
Revision: 0a0d70eb8c8652c415b78feb7d8c96f9760673f0 BUG=chromium:951322 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=neis@chromium.org Change-Id: If5e47223e38ae0c106932f6eca6529ae18b40c80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593298 Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#16} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I6c4f7038e0ed641bcc7e9fb13a603d80319d07e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592718 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#17} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
Revision: 18100666628e46ee00222df6c2be9df811599657 BUG=v8:4153,v8:7881 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jarin@chromium.org, bmeurer@chromium.org R=szuend@chromium.org Change-Id: I7bca25822b77b2e9eed698ba6717a023a891484b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594437 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#18} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Icb05506b6836803bac66de2847e46153c3550a47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594421 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#19} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
…oritative." Revision: f59744fe9ffeee1116215e23bf182ddee9fb2f67 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=miladfar@ca.ibm.com TBR=bmeurer@chromium.org, jarin@chromium.org, titzer@chromium.org Change-Id: Id544a8f7b9bb64c99ccfc1155fd892d1cf1e638f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598750 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#20} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I14a4a6eed989a55623aadb5fadc3071e3d91769b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598710 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#21} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
Revision: 87b3416a87028dc7acc57404be8cc171a32ac287 BUG=chromium:958716 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jarin@chromium.org Change-Id: I98dcd3eedaf36dde8fb6a427e682af8cdd49f71d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596741 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#22} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I14aa9ef3bbd06d961224d5f3a9a5b0a8eefc80b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598711 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#23} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
Revision: 3ce92ce8499a512e15c8ee26c83e4c2c27e3b056 BUG=chromium:952682 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Change-Id: I42907c53d6d227c37af43408b341d675c84181e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598752 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{#24} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 14, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ib0064797142c32bd6900effc7f51e9c5180f4abe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598869 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{#25} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
rogerwang
pushed a commit
that referenced
this pull request
May 31, 2019
Revision: d915b8d668615a7d6d75cf7a61d3ca5a3d139799 BUG=v8:9122 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jgruber@chromium.org Change-Id: I7afc1a80036e95b5a15464c24ae875a4acc9ba96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597023 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/branch-heads/7.4@{#55} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
rogerwang
pushed a commit
that referenced
this pull request
May 31, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ife8f49d0d8bc365a7ff11b794b61f65a288954ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600722 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.4@{#56} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
rogerwang
pushed a commit
that referenced
this pull request
May 31, 2019
Bug: chromium:951322 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ibbc656c4a22adffc7d7df305541d4264a3b199ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605722 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/branch-heads/7.4@{#57} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
rogerwang
pushed a commit
that referenced
this pull request
May 31, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I80a9a52419ed84d2085232ef9e4130ea5401052f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609654 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.4@{#58} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.