Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Windows component build #2

Closed
wants to merge 1 commit into from
Closed

fix Windows component build #2

wants to merge 1 commit into from

Conversation

hujiajie
Copy link

libplatform is forced to be built as a static library in NW.js, so USING_V8_PLATFORM_SHARED should not be defined for its direct dependents. Instead, the macro should be defined at the same place as USING_V8_SHARED since libplatform is part of the main V8 library now.

Refs: nwjs/nw.js#6172

@hujiajie
fix Windows component build
840dacb 
libplatform is forced to be built as a static library in NW.js, so
USING_V8_PLATFORM_SHARED should not be defined for its direct
dependents. Instead, the macro should be defined at the same place as
USING_V8_SHARED since libplatform is part of the main V8 library now.

Refs: nwjs/nw.js#6172
@hujiajie
Copy link
Author

@rogerwang PTAL and cherry-pick to nw26 if necessary. Thanks!

@hujiajie hujiajie mentioned this pull request Sep 27, 2017
Closed
hujiajie pushed a commit to hujiajie/v8 that referenced this pull request Oct 1, 2017
@natorion
Disable handle zapping on branch 5.9
2370b7a 
BUG=chromium:318206
TBR=jochen@chromium.org, machenbach@chromium.org
LOG=n
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2811303004 .
Cr-Commit-Position: refs/branch-heads/5.9@{nwjs#2}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{nwjs#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
hujiajie pushed a commit to hujiajie/v8 that referenced this pull request Oct 9, 2017
@otherdaniel
Disable handle zapping on branch 6.0
d83a18e 
BUG=chromium:318206
TBR=jochen@chromium.org, machenbach@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: I333abedba7dadd37e42766ac65b670336ec0693c
Reviewed-on: https://chromium-review.googlesource.com/513946
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.0@{nwjs#2}
Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{nwjs#1}
Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}
@rogerwang
Copy link
Member

merged. thanks.

@rogerwang rogerwang closed this Oct 30, 2017
rogerwang pushed a commit that referenced this pull request Nov 29, 2017
Version 6.3.292.1
2154557 
TBR=machenbach@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I419977d23adf80a7ef57e8b3d17307847f48406f
Reviewed-on: https://chromium-review.googlesource.com/715779
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#2}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
rogerwang pushed a commit that referenced this pull request Nov 29, 2017
@jungshik
Merged: Revert "Enable icu-timezone-data by default"
d734370 
This reverts commit d9a2584.
This is for 6.3 branch (to go with Chromium 63 branch). 

Reason for revert:

I'm reverting this CL for a few reasons. #2 is the most significant and
I should have thought of that before making a switch. Sorry for that.

1) perf-regression: http://crbug.com/769706
2) http://crbug.com/612010 : ICU timezone update is not propagated to
zygote process so that new tabs will hold on to an old timezone even
after a timezone change on Linux and Chrome OS.

3)  http://crbug.com/754053  : OS timezone detection issues on macOS
10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
it actually ok.

4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to

Revision: 28ef8dc

BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=adamk@chromium.org, hablich@chromium.org

Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
Reviewed-on: https://chromium-review.googlesource.com/721919
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#7}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
rogerwang pushed a commit that referenced this pull request Nov 29, 2017
@natorion
Revert "Merged: Revert "Enable icu-timezone-data by default""
3b1cfa3 
This reverts commit d734370.

Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug

Original change's description:
> Merged: Revert "Enable icu-timezone-data by default"
> 
> This reverts commit d9a2584.
> This is for 6.3 branch (to go with Chromium 63 branch). 
> 
> Reason for revert:
> 
> I'm reverting this CL for a few reasons. #2 is the most significant and
> I should have thought of that before making a switch. Sorry for that.
> 
> 1) perf-regression: http://crbug.com/769706
> 2) http://crbug.com/612010 : ICU timezone update is not propagated to
> zygote process so that new tabs will hold on to an old timezone even
> after a timezone change on Linux and Chrome OS.
> 
> 3)  http://crbug.com/754053  : OS timezone detection issues on macOS
> 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
> it actually ok.
> 
> 4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to
> 
> Revision: 28ef8dc
> 
> BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​adamk@chromium.org, hablich@chromium.org
> 
> Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
> Reviewed-on: https://chromium-review.googlesource.com/721919
> Reviewed-by: Adam Klein <adamk@chromium.org>
> Commit-Queue: Jungshik Shin <jshin@chromium.org>
> Cr-Commit-Position: refs/branch-heads/6.3@{#7}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org

Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
Reviewed-on: https://chromium-review.googlesource.com/723324
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#18}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
rogerwang pushed a commit that referenced this pull request Nov 29, 2017
@jungshik
Revert "Revert "Merged: Revert "Enable icu-timezone-data by default"""
9685d9c 
This reverts commit 3b1cfa3.

Reason for revert: ICU was not rolled in 6.3 branch leading invalid-locale test failure (that was added to test an ICU fix). Now, ICU is rolled in 6.3 branch ( https://chromium-review.googlesource.com/c/v8/v8/+/723564 ). 

Original change's description:
> Revert "Merged: Revert "Enable icu-timezone-data by default""
> 
> This reverts commit d734370.
> 
> Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug
> 
> Original change's description:
> > Merged: Revert "Enable icu-timezone-data by default"
> > 
> > This reverts commit d9a2584.
> > This is for 6.3 branch (to go with Chromium 63 branch). 
> > 
> > Reason for revert:
> > 
> > I'm reverting this CL for a few reasons. #2 is the most significant and
> > I should have thought of that before making a switch. Sorry for that.
> > 
> > 1) perf-regression: http://crbug.com/769706
> > 2) http://crbug.com/612010 : ICU timezone update is not propagated to
> > zygote process so that new tabs will hold on to an old timezone even
> > after a timezone change on Linux and Chrome OS.
> > 
> > 3)  http://crbug.com/754053  : OS timezone detection issues on macOS
> > 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
> > it actually ok.
> > 
> > 4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to
> > 
> > Revision: 28ef8dc
> > 
> > BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
> > LOG=N
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > R=​adamk@chromium.org, hablich@chromium.org
> > 
> > Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
> > Reviewed-on: https://chromium-review.googlesource.com/721919
> > Reviewed-by: Adam Klein <adamk@chromium.org>
> > Commit-Queue: Jungshik Shin <jshin@chromium.org>
> > Cr-Commit-Position: refs/branch-heads/6.3@{#7}
> > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
> 
> TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org
> 
> Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
> Reviewed-on: https://chromium-review.googlesource.com/723324
> Reviewed-by: Michael Hablich <hablich@chromium.org>
> Commit-Queue: Michael Hablich <hablich@chromium.org>
> Cr-Commit-Position: refs/branch-heads/6.3@{#18}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org

Change-Id: I8f712f1e6eb1f14c703ffe9f1d63d23b4b4bb08e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
Reviewed-on: https://chromium-review.googlesource.com/723962
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#21}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
GnorTech pushed a commit that referenced this pull request Dec 12, 2017
@jungshik
Revert "Enable icu-timezone-data by default"
28ef8dc 
This reverts commit d9a2584.

Reason for revert: 

I'm reverting this CL for a few reasons. #2 is the most significant and I should have thought of that before making a switch. Sorry for that.   

1) perf-regression: http://crbug.com/769706
2) http://crbug.com/612010 : ICU timezone update is not propagated to zygote process so that new tabs will hold on to an old timezone even after a timezone change on Linux and Chrome OS. 
3) http://crbug.com/754053 : OS timezone detection issues on macOS 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So, it actually ok.  
4) http://crbug.com/771868 : timezone wrong in gmail: If it's due to #3, we're fine because it's fixed. If not, we need to look more.

Original change's description:
> Enable icu-timezone-data by default
> 
> This will introduce a new behavior on POSIX(-like) platforms. Timezone
> names inside parentheses after GMT offset will not be 3-4 letter
> abbreviation any longer. They'll be human-readable names in the current
> default locale. This matches the current Windows behavior.
> 
> new Date(2017, 5, 22).toString()
> new Date(2017, 11, 22).toString()
> 
> Current:
> 
> Thu Jun 22 2017 00:00:00 GMT-0700 (PDT)
> Fri Dec 22 2017 00:00:00 GMT-0800 (PST)
> 
> New in en-US locale:
> 
> Thu Jun 22 2017 00:00:00 GMT-0700 (Pacific Daylight Time)
> Fri Dec 22 2017 00:00:00 GMT-0800 (Pacific Standard Time)
> 
> New in German locale:
> 
> Thu Jun 22 2017 00:00:00 GMT-0700 (Nordamerikanische Westküsten-Sommerzeit)
> Fri Dec 22 2017 00:00:00 GMT-0800 (Nordamerikanische Westküsten-Normalzeit)
> 
> BUG=v8:6031, v8:2137, v8:6076
> TEST=mjsunit/icu-date-lord-howe.js, mjsunit/icu-date-to-string.js
> 
> Change-Id: I4e7fd8b3ddae5c7779e220c4c101e45904fcdc01
> Reviewed-on: https://chromium-review.googlesource.com/625164
> Commit-Queue: Jungshik Shin <jshin@chromium.org>
> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#47953}

TBR=adamk@chromium.org,littledan@chromium.org,jshin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:6031, v8:2137, v8:6076, chromium:769706, chromium:612010, chromium:771868
Change-Id: I60d75467ee21975d3a235344b01c0d2d44a7da96
Reviewed-on: https://chromium-review.googlesource.com/713404
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48478}
GnorTech pushed a commit that referenced this pull request Dec 12, 2017
Version 6.4.388.1
30003d9 
TBR=machenbach@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I8b37bbfeefc6b5053e5f19b0f9072f6591ae8650
Reviewed-on: https://chromium-review.googlesource.com/800250
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.4@{#2}
Cr-Branched-From: 0407506-refs/heads/6.4.388@{#1}
Cr-Branched-From: a5fc4e0-refs/heads/master@{#49724}
GnorTech pushed a commit that referenced this pull request Jan 26, 2018
Version 6.5.254.1
f5c01ff 
TBR=machenbach@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia610fe90e80445abd8c109294e1fc95e9ac149f3
Reviewed-on: https://chromium-review.googlesource.com/873610
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.5@{#2}
Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1}
Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Version 6.6.346.1
8aca331 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I0fbad03d504ff721195f12bd9b72f9f25a865941
Reviewed-on: https://chromium-review.googlesource.com/942941
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.6@{#2}
Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
rogerwang pushed a commit that referenced this pull request Apr 22, 2018
@natorion
Version 6.7.288.1 (cherry-pick)
8457e81 
Merged 225bc87

Revert '[runtime] Temporarily disable double fields unboxing.'

R=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I1f66400e57553d3c0909da6b1f536ad9f76a8ce1
Reviewed-on: https://chromium-review.googlesource.com/1009904
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@natorion
Create V8 6.7 branch for Chrome 67
13bb092 
TBR=machenbach@chromium.org

Change-Id: If70aa1459ed6e909a604925ae5b977617a53d32f
Reviewed-on: https://chromium-review.googlesource.com/1010123
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#1}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@natorion
Disable handle zapping on branch 6.7
c8a640b 
No more GYP file to modify because GYP is gone.

BUG=chromium:318206
TBR=jochen@chromium.org, machenbach@chromium.org
LOG=n
NOTRY=true
NOPRESUBMIT=true

Change-Id: I309acad941ade2422d2a4edf99279ba59aae7aed
Reviewed-on: https://chromium-review.googlesource.com/1010142
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#2}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.2
1d33033 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: If3012fd8856b20ff448b957202950ec755ff13d7
Reviewed-on: https://chromium-review.googlesource.com/1010105
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#3}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@natorion
Whitespace change to trigger infra
9f21df6 
TBR=machenbach@chromium.org

Change-Id: I9750ce6748377831579200af4f3f5db2f867aaf3
Reviewed-on: https://chromium-review.googlesource.com/1009911
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#4}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.3
6068cbf 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I95a6ccba183c7d06a45467771ddbcbefef6608ab
Reviewed-on: https://chromium-review.googlesource.com/1010242
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#5}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Merged: PPC/s390: Fix endianess issue on Generate_ConstructFunction
278d46d 
Revision: fa549bc

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=joransiu@ca.ibm.com

Change-Id: Ib96253ccd216b6254f7a4b44306154a0a3ea29ca
Reviewed-on: https://chromium-review.googlesource.com/1011260
Reviewed-by: Joran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/branch-heads/6.7@{#6}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.4
6134da2 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ibe7af80e2d88e9bd799b8649fe6d009038270bea
Reviewed-on: https://chromium-review.googlesource.com/1011110
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#7}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Merged: PPC/s390: fix endianess issue in Generate_InterpreterEntryTra…
a33763f 
…mpoline

Revision: ebe3e44

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=joransiu@ca.ibm.com

Change-Id: I6c3a7017c79770a87cbe52398aa6cb3625d14d00
Reviewed-on: https://chromium-review.googlesource.com/1011115
Reviewed-by: Joran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/branch-heads/6.7@{#8}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.5
79afb66 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: If39020cd008e4b467d94fab1fd2da46bd72478bb
Reviewed-on: https://chromium-review.googlesource.com/1011329
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#9}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Merged: PPC/s390: interpreter: make interpreted frames distinguishabl…
4ea9790 
…e in the native stack

Revision: c7393ac

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=joransiu@ca.ibm.com

Change-Id: I96ace2aef3da4b590072517f339d7120bc1a6060
Reviewed-on: https://chromium-review.googlesource.com/1012536
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/branch-heads/6.7@{#10}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.6
963e449 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I0277afb7a39077ae51cef9156471cb2dec3444e7
Reviewed-on: https://chromium-review.googlesource.com/1013603
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#11}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@peterwmwong
Merged: [builtins] Fix missing ToString in RegExp.p.match
9a443d2 
It is not safe to assume the first match is a string just
because the RegExp result is fast.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Bug: chromium:831943
Change-Id: Idd40f8b75312f0be54f45f626dc017339033abc6
Reviewed-on: https://chromium-review.googlesource.com/1009325
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Original-Commit-Position: refs/heads/master@{#52578}(cherry picked from commit 7bdbe77)
Reviewed-on: https://chromium-review.googlesource.com/1013578
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#12}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Version 6.7.288.7
eefd069 
TBR=machenbach@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I9b2e7e0163f17b6146b84252a0b2273a841c16ab
Reviewed-on: https://chromium-review.googlesource.com/1013746
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#13}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
Version 7.3.492.15
95d8c8d 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ib20660a9fcb36bbd1201cb79495fbac3956db347
Reviewed-on: https://chromium-review.googlesource.com/c/1478712
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#27}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
@targos
Merged: Update postmortem metadata generation script
8827ab5 
Revision: b364ceb

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Bug: v8:8792
Change-Id: Id3a7abe442bd156170459e2a0e605dd271e06227
Reviewed-on: https://chromium-review.googlesource.com/c/1473031
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#28}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
Version 7.3.492.16
becc391 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I2d37d00160ffa9d738b99df5805cdabeba6998c8
Reviewed-on: https://chromium-review.googlesource.com/c/1485246
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#29}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
@jkunkee
Merged: DISALLOW_IMPLICIT_CONSTRUCTORS for MacroAssembler
47e3422 
Backport of CL #1454676. In short, marking classes for export means
that DISALLOW_IMPLICIT_CONSTRUCTORS needs to be manually propagated
so they aren't exported by V8_EXPORT_PRIVATE.

Backporting this change allows BUILDING_V8_SHARED builds to succeed,
such as during is_component_build=true builds and Node.js builds.

Revision: 9e060e4

BUG=v8:8870,v8:8871
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=jgruber@chromium.org

Change-Id: Ia8cd2bc06f0ebe69c637717d94642377a25a718d
Reviewed-on: https://chromium-review.googlesource.com/c/1474557
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#30}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
Version 7.3.492.17
a65a4fc 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie21555cc65a13f6be166988ee2c1476b3b3ef6b8
Reviewed-on: https://chromium-review.googlesource.com/c/1485247
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#31}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
@mi-ac
Merged: Roll luci/client-py to tip of tree.
f31c743 
Revision: c7efd0d

LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=sergiyb@chromium.org

Bug: chromium:934482,chromium:935999
Change-Id: Ic94fe470b0a1bbd07a20839c535bf31deebb2971
Reviewed-on: https://chromium-review.googlesource.com/c/1491212
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#32}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
Version 7.3.492.18
6c56416 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I5b1fec4478ff469c24c0d07650f228ee224aab96
Reviewed-on: https://chromium-review.googlesource.com/c/1490606
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#33}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
@verwaest
Merged: [parser] Reset expression_scope_ stack to nullptr when parsin…
368f181 
…g a function body

Revision: 486ec80

R=leszeks@chromium.org
BUG=chromium:930580
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I9aa6393b97afed7687e8481e2615dfc6f537a05b
Reviewed-on: https://chromium-review.googlesource.com/c/1494757
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#34}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 4, 2019
Version 7.3.492.19
a8a51d8 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie4b14cde3d352471737acd7a7d735ed42171ba29
Reviewed-on: https://chromium-review.googlesource.com/c/1494777
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#35}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@verwaest
Merged: [ast] Always visit all AST nodes, even dead nodes
03a5fd9 
Revision: 9439a1d

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=leszeks@chromium.org

Bug: chromium:926651
Change-Id: I24da2ec5c87a7a1489a7d186fae69cc196ffe503
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503378
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#36}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
Version 7.3.492.20
3f95661 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I42d7ee0eb9213c878041bec12a9f605d3974bbc4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503557
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#37}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@jkunkee
Merged: Squashed multiple commits.
00d216f 
Merged: snapshot: add source line stubs for ARM64 Windows
Revision: 58cefed

Merged: Move ARM64 Assembler::nop definition from header to source file
Revision: 7803fa6

BUG=chromium:893460,v8:8870
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=jgruber@chromium.org

Change-Id: Idc2623b2f12220e42ddb9388a36d4f02ff2a1409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506201
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#38}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
Version 7.3.492.21
749d931 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4a009bfe2825d76f4efbcf91c741be63f43feeb3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510580
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#39}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@szuend @jakobkummerow
[heap] Throw OOM when allocating FixedDoubleArrays with negative length
9baef68 
Bug: chromium:938251
Change-Id: I336765c894cc78ca822904a32356db43feadea07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505312
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#60051}(cherry picked from commit 4edcc86)
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511629
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#40}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@jakobkummerow
Whitespace change to trigger bots
9b9b2ca 
Change-Id: I4bc73cf01cf7628d2030bed76eeaab02ad749de7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1512717
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#41}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@ajklein
Whitespace change to attempt bot triggering yet agin
92e93af 
Change-Id: Ifca54bad6d9209c5521890a735c3b01ed7855dc6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513935
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#42}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 12, 2019
@ajklein
Version 7.3.492.22
db22c3f 
This is an attempt to override the busted autotag bot.

Bug: v8:8972
Change-Id: I745c377f1e1991b2c00d61fc0a5ffad3655df7cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513937
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#43}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
@mi-ac
Whitespace change to trigger tag bot
e2a94b3 
Change-Id: I475d0a42d5845beb62573c59d316c3b89e8acd1b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514733
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#44}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
Version 7.3.492.23
53cb66e 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ia13ab16f00246231479d6718a9cc3a7c70c078a9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514853
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#45}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
Merged: Squashed multiple commits.
06456fa 
Merged: aix: fix function_descriptor issue on regexp
Revision: 4706fa7

Merged: PPC: removed AIX function descriptors in tests
Revision: 8104f1d

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=jgruber@chromium.org, mstarzinger@chromium.org

Change-Id: I445b066b2a287822876cc0dc5b8080b671bc4565
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1512112
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#46}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
Version 7.3.492.24
e0913c2 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Idc0e4b2ca5296ec3623db08d1de1996be9d4eb95
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1512931
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#47}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
@mi-ac
Whitespace change to trigger auto-tag builder
91098f8 
Change-Id: I17d7c5a3258e9c819ac48beb604d00f536a2b24a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514841
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#48}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 21, 2019
Version 7.3.492.25
51df567 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Idbc16225a777fefbd33cb558c82613a3e8a7d00d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514855
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#49}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@natorion
Disable handle zapping
0e1e178 
Bug=chromium:318206
TBR=machenbach@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: Ia08fa4b7c3d025c061337b40891a9e0bcfc699b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507716
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.4@{#2}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
rogerwang pushed a commit that referenced this pull request Apr 6, 2019
@ripsawridge
Merged: Squashed multiple commits.
47ca28a 
Merged: [TurboFan] Array.prototype.map wrong ElementsKind for output array.
Revision: 96de5ee

Merged: Fix arm/arm64 simulator test timeouts
Revision: 6f2b87b

BUG=chromium:941743
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=jarin@chromium.org

Change-Id: Idb2160102b1ae412b02c26b9d009587b3c0a6fa3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532326
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#50}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Apr 6, 2019
Version 7.3.492.26
c8d255f 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ia801d63a7ae0d4887c4e64e1b07321790324b3df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532971
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#51}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Apr 6, 2019
@isheludko
Merged: [regexp] Refactor Regexp.prototype[@@replace]
09e4216 
Revision: 2ee4300

BUG=chromium:944971
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I7fb88c7898d63e92deffa3367862105d657ad8a0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547659
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.3@{#52}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request Apr 6, 2019
Version 7.3.492.27
6ea7920 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I86bb294f41d09f0f651c33ffa3da207ba554e8b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547417
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{#53}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
rogerwang pushed a commit that referenced this pull request May 3, 2019
@natorion
Revert "[wasm] Add stack guard for logging code"
6ce63fd 
This reverts commit 067ba2a.

Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1570208

21:26:22.251 27507   # Fatal error in ../../v8/src/profiler/profile-generator.cc, line 19
21:26:22.251 27507   # Debug check failed: line > 0 (0 vs. 0).
21:26:22.251 27507   #
21:26:22.251 27507   #
21:26:22.251 27507   #
21:26:22.252 27507   #FailureMessage Object: 0x7ffe851046a0#0 0x56532cb371f9 base::debug::CollectStackTrace()
21:26:22.252 27507   #1 0x56532ca70863 base::debug::StackTrace::StackTrace()
21:26:22.252 27507   #2 0x56532e99610b gin::(anonymous namespace)::PrintStackTrace()
21:26:22.252 27507   #3 0x56532e989468 V8_Fatal()
21:26:22.252 27507   #4 0x56532e9891c5 v8::base::(anonymous namespace)::DefaultDcheckHandler()
21:26:22.252 27507   #5 0x56532b2bb876 v8::internal::SourcePositionTable::SetPosition()
21:26:22.252 27507   #6 0x56532b2c2268 v8::internal::ProfilerListener::CodeCreateEvent()
21:26:22.252 27507   #7 0x56532ae25275 v8::internal::(anonymous namespace)::LogFunctionCompilation()
21:26:22.252 27507   #8 0x56532ae26008 v8::internal::OptimizedCompilationJob::RecordFunctionCompilation()
21:26:22.252 27507   #9 0x56532ae32a08 v8::internal::Compiler::FinalizeOptimizedCompilationJob()
21:26:22.252 27507   #10 0x56532ae228eb v8::internal::OptimizingCompileDispatcher::InstallOptimizedFunctions()
21:26:22.252 27507   #11 0x56532af14e4a v8::internal::StackGuard::HandleInterrupts()
21:26:22.252 27507   #12 0x56532b35f2ec v8::internal::__RT_impl_Runtime_StackGuard()
21:26:22.252 27507   #13 0x56532bba6720 <unknown>

Original change's description:
> [wasm] Add stack guard for logging code
> 
> Benchmarks or worker threads might never return to the event queue,
> hence they will never execute the scheduled foreground task to log
> compiled and published wasm code.
> This CL adds a stack guard to log the code, to ensure that we also log
> it for wasm code that never returns to the event queue.
> 
> R=​mstarzinger@chromium.org
> 
> Bug: v8:9104
> Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60879}

TBR=mstarzinger@chromium.org,clemensh@chromium.org

Change-Id: I63dc56a41747caf683b14869a2d62017fd0301c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9104
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570012
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60890}
rogerwang pushed a commit that referenced this pull request May 7, 2019
@natorion
Disable handle zapping
20da4fa 
Bug=chromium:318206
TBR=machenbach@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: Ib28c17e0d08985813b0ba8136fb747714e80a599
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571611
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.5@{#2}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerwang rogerwang rogerwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hujiajie @rogerwang