Remove no longer used channel_uuid and channel_type fields from msg events
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent payload queued to mailroom
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 74.55% 74.54% -0.01%
==========================================
Files 98 98
Lines 12448 12445 -3
==========================================
- Hits 9280 9277 -3
Misses 2512 2512
Partials 656 656
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rowanseymour
commented
Oct 17, 2022
| @@ -1152,7 +1150,6 @@ func (ts *BackendTestSuite) TestWriteMsg() { | |||
| "text": msg.Text(), | |||
| "attachments": nil, | |||
| "new_contact": contact.IsNew_, | |||
| "created_on": msg.CreatedOn_.Format(time.RFC3339Nano), | |||
There was a problem hiding this comment.
also not used https://github.com/nyaruka/mailroom/pull/679
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end mailroom just uses
channel_id