Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer used channel_uuid and channel_type fields from msg events #529

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Remove no longer used channel_uuid and channel_type fields from msg events #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b628b8b
Remove no longer used channel_uuid and channel_type fields from msg e…
rowanseymour Oct 17, 2022
e870be4
Remove created_on field which also isn't used
rowanseymour Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backends/rapidpro/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,8 +1142,6 @@ func (ts *BackendTestSuite) TestWriteMsg() {
"contact_id": float64(contact.ID_),
"org_id": float64(1),
"channel_id": float64(10),
"channel_uuid": "dbc126ed-66bc-4e28-b67b-81dc3327c95d",
"channel_type": "KN",
"msg_id": float64(msg.ID_),
"msg_uuid": msg.UUID_.String(),
"msg_external_id": msg.ExternalID(),
Expand All @@ -1152,7 +1150,6 @@ func (ts *BackendTestSuite) TestWriteMsg() {
"text": msg.Text(),
"attachments": nil,
"new_contact": contact.IsNew_,
"created_on": msg.CreatedOn_.Format(time.RFC3339Nano),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not used https://github.com/nyaruka/mailroom/pull/679

}, body["task"])
}

Expand Down
3 changes: 0 additions & 3 deletions backends/rapidpro/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ func queueMsgHandling(rc redis.Conn, c *DBContact, m *DBMsg) error {
"contact_id": c.ID_,
"org_id": channel.OrgID_,
"channel_id": channel.ID_,
"channel_uuid": channel.UUID_, // deprecated
"channel_type": channel.ChannelType_, // deprecated
"msg_id": m.ID_,
"msg_uuid": m.UUID_.String(),
"msg_external_id": m.ExternalID(),
Expand All @@ -27,7 +25,6 @@ func queueMsgHandling(rc redis.Conn, c *DBContact, m *DBMsg) error {
"text": m.Text(),
"attachments": m.Attachments(),
"new_contact": c.IsNew_,
"created_on": m.CreatedOn_,
}

return queueMailroomTask(rc, "msg_event", m.OrgID_, m.ContactID_, body)
Expand Down