Use overflow sub and unit test #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added |
dannywillems
commented
Jun 3, 2024
querolita
approved these changes
Jun 4, 2024
querolita
force-pushed
the
zkvm/mips/test-load16
branch
from
34ce0c6
to
f707fba
Compare
querolita
force-pushed
the
dw/use-overflow-sub-interpreter-mips
branch
from
beeb5cc
to
9003628
Compare
querolita
changed the base branch from
zkvm/mips/test-load16
to
zkvm/mips/make_test_rng_seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add tests. DO NOT MERGE.